components/visitedlink/test/visitedlink_unittest.cc - Issue 2684993011: Revert of Make TestRenderWidgetHostView::Show/Hide call through to RWHI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/visitedlink/test/visitedlink_unittest.cc

Issue 2684993011: Revert of Make TestRenderWidgetHostView::Show/Hide call through to RWHI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@crash

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/push_messaging/push_messaging_notification_manager_unittest.cc ('k') | content/browser/web_contents/web_contents_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/visitedlink/test/visitedlink_unittest.cc

diff --git a/components/visitedlink/test/visitedlink_unittest.cc b/components/visitedlink/test/visitedlink_unittest.cc

index e5f61eebf8334e68dbd3b85e400cf63c133e0f06..d53c5a4db908611ba1b660d3766306d6db0fc1f4 100644

--- a/components/visitedlink/test/visitedlink_unittest.cc

+++ b/components/visitedlink/test/visitedlink_unittest.cc

@@ -30,8 +30,6 @@

#include "content/public/browser/browser_thread.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/notification_types.h"

-#include "content/public/browser/render_widget_host_view.h"

-#include "content/public/browser/web_contents.h"

#include "content/public/test/mock_render_process_host.h"

#include "content/public/test/test_browser_context.h"

#include "content/public/test/test_browser_thread_bundle.h"

@@ -789,7 +787,7 @@

EXPECT_EQ(1, context()->reset_event_count());

// Simulate tab becoming inactive.

- web_contents()->GetRenderWidgetHostView()->Hide();

+ RenderViewHostTester::For(rvh())->SimulateWasHidden();

// Add a few URLs.

master()->AddURL(GURL("http://acidtests.org/"));

@@ -804,7 +802,7 @@

EXPECT_EQ(1, context()->reset_event_count());

// Simulate the tab becoming active.

- web_contents()->GetRenderWidgetHostView()->Show();

+ RenderViewHostTester::For(rvh())->SimulateWasShown();

context()->WaitForUpdate();

// We should now have 3 add events, still no reset events.

@@ -812,7 +810,7 @@

EXPECT_EQ(1, context()->reset_event_count());

// Deactivate the tab again.

- web_contents()->GetRenderWidgetHostView()->Hide();

+ RenderViewHostTester::For(rvh())->SimulateWasHidden();

// Add a bunch of URLs (over 50) to exhaust the link event buffer.

for (int i = 0; i < 100; i++)

@@ -827,7 +825,7 @@

EXPECT_EQ(1, context()->reset_event_count());

// Activate the tab.

- web_contents()->GetRenderWidgetHostView()->Show();

+ RenderViewHostTester::For(rvh())->SimulateWasShown();

EXPECT_FALSE(timer_->IsRunning());

context()->WaitForUpdate();