chrome/browser/push_messaging/push_messaging_notification_manager_unittest.cc - Issue 2684993011: Revert of Make TestRenderWidgetHostView::Show/Hide call through to RWHI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/push_messaging/push_messaging_notification_manager_unittest.cc

Issue 2684993011: Revert of Make TestRenderWidgetHostView::Show/Hide call through to RWHI (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@crash

Patch Set: Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_context_menu_model_unittest.cc ('k') | components/visitedlink/test/visitedlink_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/push_messaging/push_messaging_notification_manager_unittest.cc

diff --git a/chrome/browser/push_messaging/push_messaging_notification_manager_unittest.cc b/chrome/browser/push_messaging/push_messaging_notification_manager_unittest.cc

index a1fdaff1deb4ee38c3636431b065d01f534f69e8..f6c8556e3ca45e2224c2ccf82f89484aa004e58d 100644

--- a/chrome/browser/push_messaging/push_messaging_notification_manager_unittest.cc

+++ b/chrome/browser/push_messaging/push_messaging_notification_manager_unittest.cc

@@ -6,8 +6,8 @@

#include "chrome/test/base/chrome_render_view_host_test_harness.h"

#include "chrome/test/base/testing_profile.h"

-#include "content/public/browser/render_widget_host_view.h"

#include "content/public/browser/web_contents.h"

+#include "content/public/test/test_renderer_host.h"

#include "testing/gtest/include/gtest/gtest.h"

#include "url/gurl.h"

@@ -25,10 +25,10 @@

GURL("https://chrome.com/")));

EXPECT_TRUE(manager.IsTabVisible(profile(), web_contents(), origin));

- web_contents()->GetRenderWidgetHostView()->Hide();

+ content::RenderViewHostTester::For(rvh())->SimulateWasHidden();

EXPECT_FALSE(manager.IsTabVisible(profile(), web_contents(), origin));

- web_contents()->GetRenderWidgetHostView()->Show();

+ content::RenderViewHostTester::For(rvh())->SimulateWasShown();

EXPECT_TRUE(manager.IsTabVisible(profile(), web_contents(), origin));

}

@@ -43,6 +43,6 @@

ASSERT_EQ(view_source_page, web_contents()->GetVisibleURL());

EXPECT_TRUE(manager.IsTabVisible(profile(), web_contents(), origin));

- web_contents()->GetRenderWidgetHostView()->Hide();

+ content::RenderViewHostTester::For(rvh())->SimulateWasHidden();

EXPECT_FALSE(manager.IsTabVisible(profile(), web_contents(), origin));

}