Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2684983005: Merged: [key] Fix for-in with trailing shadowing keys with dict-mode receiver (Closed)

Created:
3 years, 10 months ago by Camillo Bruni
Modified:
3 years, 10 months ago
Reviewers:
Michael Hablich
CC:
ulan, v8-merges_googlegroups.com, v8-reviews_googlegroups.com
Target Ref:
refs/pending/branch-heads/5.7
Project:
v8
Visibility:
Public.

Description

Merged: [key] Fix for-in with trailing shadowing keys with dict-mode receiver Revision: d0bccc9c6ad5c843dd6d3dff628770f122b6cb63 BUG=688307 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=hablich@chromium.org Review-Url: https://codereview.chromium.org/2684983005 . Cr-Commit-Position: refs/branch-heads/5.7@{#90} Cr-Branched-From: 975e9a320b6eaf9f12280c35df98e013beb8f041-refs/heads/5.7.492@{#1} Cr-Branched-From: 8d76f0e3465a84bbf0bceab114900fbe75844e1f-refs/heads/master@{#42426} Committed: https://chromium.googlesource.com/v8/v8/+/4e083b1a151f77d2f474980bba648b125ef0771c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M src/objects.cc View 2 chunks +2 lines, -1 line 0 comments Download
M test/mjsunit/for-in.js View 1 chunk +26 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Camillo Bruni
3 years, 10 months ago (2017-02-09 09:42:11 UTC) #1
Camillo Bruni
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-02-09 09:42:12 UTC) #2
Michael Hablich
lgtm
3 years, 10 months ago (2017-02-09 09:50:22 UTC) #3
Camillo Bruni
3 years, 10 months ago (2017-02-09 09:59:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4e083b1a151f77d2f474980bba648b125ef0771c.

Powered by Google App Engine
This is Rietveld 408576698