Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(520)

Issue 2684973005: Check if the next text node has a leading white space (Closed)

Created:
3 years, 10 months ago by joone
Modified:
3 years, 10 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check if the next text node has a leading white space In the previous CL(https://crrev.com/2432083003), we only checked the leading space of the next text node, but we need to check all kinds of white space including enter. BUG=661375 TEST=editing/inserting/insert-space.html Review-Url: https://codereview.chromium.org/2684973005 Cr-Commit-Position: refs/heads/master@{#449251} Committed: https://chromium.googlesource.com/chromium/src/+/5b9a9a6f8c9c646ac542a9e1a2f18c59140849e6

Patch Set 1 #

Patch Set 2 : add test case #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M third_party/WebKit/LayoutTests/editing/inserting/insert-space.html View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 19 (15 generated)
joone
Hi yosin@ please review this CL.
3 years, 10 months ago (2017-02-09 07:54:24 UTC) #10
yosin_UTC9
lgtm
3 years, 10 months ago (2017-02-09 09:26:17 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684973005/20001
3 years, 10 months ago (2017-02-09 09:26:34 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 10:05:18 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/5b9a9a6f8c9c646ac542a9e1a2f1...

Powered by Google App Engine
This is Rietveld 408576698