Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2684963002:
[turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++ builtins. (Closed)
|
Created:
3 years, 10 months ago by Benedikt Meurer Modified:
3 years, 8 months ago Reviewers:
danno CC:
v8-reviews_googlegroups.com Target Ref:
refs/heads/master Project:
v8 Visibility:
Public. |
Description[turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++ builtins.
When we call from TurboFan to a CSA or C++ builtin, we can avoid the
ArgumentsAdaptorFrame in case of a parameter arity mismatch by just
filling up missing arguments with undefined or removing additional
arguments on the call site already. This is safe for CSA/C++ builtins,
since those that care about variable arguments are marked with the
kDontAdaptArgumentsSentinel.
R=danno@chromium.org
BUG=v8:5267
Review-Url: https://codereview.chromium.org/2684963002
Cr-Commit-Position: refs/heads/master@{#44218}
Committed: https://chromium.googlesource.com/v8/v8/+/9df5674bd53b4a262e72f45263df9e886842c269
Patch Set 1 #Patch Set 2 : Obviously do this only for native functions. #Patch Set 3 : Exclude JavaScript builtins. #Messages
Total messages: 22 (16 generated)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Nice. lgtm.
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by bmeurer@chromium.org
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danno@chromium.org Link to the patchset: https://codereview.chromium.org/2684963002/#ps20001 (title: "Obviously do this only for native functions.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_asan_rel_ng on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_asan_rel_ng_triggered on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
The CQ bit was checked by bmeurer@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by bmeurer@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from danno@chromium.org Link to the patchset: https://codereview.chromium.org/2684963002/#ps40001 (title: "Exclude JavaScript builtins.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1490772691806910,
"parent_rev": "f11719ce793ad3c664127a379413c0c3cffc5685", "commit_rev":
"9df5674bd53b4a262e72f45263df9e886842c269"}
Message was sent while issue was closed.
Description was changed from ========== [turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++ builtins. When we call from TurboFan to a CSA or C++ builtin, we can avoid the ArgumentsAdaptorFrame in case of a parameter arity mismatch by just filling up missing arguments with undefined or removing additional arguments on the call site already. This is safe for CSA/C++ builtins, since those that care about variable arguments are marked with the kDontAdaptArgumentsSentinel. R=danno@chromium.org BUG=v8:5267 ========== to ========== [turbofan] Avoid going through ArgumentsAdaptorTrampoline for CSA/C++ builtins. When we call from TurboFan to a CSA or C++ builtin, we can avoid the ArgumentsAdaptorFrame in case of a parameter arity mismatch by just filling up missing arguments with undefined or removing additional arguments on the call site already. This is safe for CSA/C++ builtins, since those that care about variable arguments are marked with the kDontAdaptArgumentsSentinel. R=danno@chromium.org BUG=v8:5267 Review-Url: https://codereview.chromium.org/2684963002 Cr-Commit-Position: refs/heads/master@{#44218} Committed: https://chromium.googlesource.com/v8/v8/+/9df5674bd53b4a262e72f45263df9e88684... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/v8/v8/+/9df5674bd53b4a262e72f45263df9e88684... |
