[Cronet] Fix compilation and test errors for CookieStoreIOS.

[Cronet] Fix compilation and test errors for CookieStoreIOS.

BUG=679736
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2684933009
Cr-Commit-Position: refs/heads/master@{#449669}
Committed: https://chromium.googlesource.com/chromium/src/+/674565161b44e1505e220f1864803647698d9a8e

[mef, 2017-02-09 19:52:41]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 19:53:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2017-02-09 19:54:47]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 19:55:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2017-02-09 19:57:13]

mef@chromium.org changed reviewers:
+ eugenebut@chromium.org, lilyhoughton@chromium.org

[mef, 2017-02-09 19:57:14]

PTAL. This fixes compilation and test errors caused by
https://codereview.chromium.org/2649083002/

[commit-bot: I haz the power, 2017-02-09 20:22:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 20:22:12]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-02-10 00:17:02]

lgtm Sorry for breaking this

https://codereview.chromium.org/2684933009/diff/20001/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_store_ios.mm (right):

https://codereview.chromium.org/2684933009/diff/20001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios.mm:594: return [system_store_
cookieAcceptPolicy] != NSHTTPCookieAcceptPolicyNever;
This will return YES if 3rd party cookies are blocked. Is it ok? Should
|CrNetEnvironment::InitializeOnNetworkThread| set
|NSHTTPCookieAcceptPolicyAlways| policy to |sharedHTTPCookieStorage| instead?

[lilyhoughton, 2017-02-10 16:41:18]

lgtm otherwise

https://codereview.chromium.org/2684933009/diff/20001/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_store_ios.mm (right):

https://codereview.chromium.org/2684933009/diff/20001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios.mm:594: return [system_store_
cookieAcceptPolicy] != NSHTTPCookieAcceptPolicyNever;
What is the specific issue that this change fixes?

[mef, 2017-02-10 17:01:46]

Description was changed from

==========
[Cronet] Fix compilation and test errors for CookieStoreIOS.

BUG=679736
==========

to

==========
[Cronet] Fix compilation and test errors for CookieStoreIOS.

BUG=679736
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

[mef, 2017-02-10 17:01:53]

The CQ bit was checked by mef@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 17:02:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mef, 2017-02-10 17:04:59]

Thanks for your suggestions, could you take another look?

https://codereview.chromium.org/2684933009/diff/20001/ios/net/cookies/cookie_...
File ios/net/cookies/cookie_store_ios.mm (right):

https://codereview.chromium.org/2684933009/diff/20001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios.mm:594: return [system_store_
cookieAcceptPolicy] != NSHTTPCookieAcceptPolicyNever;
On 2017/02/10 00:17:01, Eugene But wrote:
> This will return YES if 3rd party cookies are blocked. Is it ok? Should
> |CrNetEnvironment::InitializeOnNetworkThread| set
> |NSHTTPCookieAcceptPolicyAlways| policy to |sharedHTTPCookieStorage| instead?

Done.

https://codereview.chromium.org/2684933009/diff/20001/ios/net/cookies/cookie_...
ios/net/cookies/cookie_store_ios.mm:594: return [system_store_
cookieAcceptPolicy] != NSHTTPCookieAcceptPolicyNever;
On 2017/02/10 16:41:18, lilyhoughton wrote:
> What is the specific issue that this change fixes?

It broke Cronet cookie tests. 
I've entered crbug.com/690969 to track this. 
I think we should change Cronet behavior, but first I want to restore existing
functionality.

[commit-bot: I haz the power, 2017-02-10 17:35:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 17:35:31]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-02-10 18:35:19]

still lgtm

[mef, 2017-02-10 18:35:56]

The CQ bit was checked by mef@chromium.org

[mef, 2017-02-10 18:35:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
lilyhoughton@chromium.org
Link to the patchset: https://codereview.chromium.org/2684933009/#ps40001
(title: "Address Eugene's suggestions.")

[commit-bot: I haz the power, 2017-02-10 18:36:36]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 18:44:28]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1486751756005680,
"parent_rev": "5fb4064595996e5f0ae942d928e3bccc5209bca7", "commit_rev":
"674565161b44e1505e220f1864803647698d9a8e"}

[commit-bot: I haz the power, 2017-02-10 18:45:51]

Description was changed from

==========
[Cronet] Fix compilation and test errors for CookieStoreIOS.

BUG=679736
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester
==========

to

==========
[Cronet] Fix compilation and test errors for CookieStoreIOS.

BUG=679736
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_cronet_tester

Review-Url: https://codereview.chromium.org/2684933009
Cr-Commit-Position: refs/heads/master@{#449669}
Committed:
https://chromium.googlesource.com/chromium/src/+/674565161b44e1505e220f186480...
==========

[commit-bot: I haz the power, 2017-02-10 18:45:52]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/674565161b44e1505e220f186480...