Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2684893003: Revert of android: Report java exception in child (Closed)

Created:
3 years, 10 months ago by boliu
Modified:
3 years, 10 months ago
CC:
chromium-reviews, jam, darin-cc_chromium.org, sadrul, kalyank
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of android: Report java exception in child (patchset #2 id:20001 of https://codereview.chromium.org/2677563006/ ) Reason for revert: tobiasjs@ pointed out: DumpWithoutCrash doesn't really work on android in child processes since android child processes sends the dump through a FD, and browser only picks up the FD after it detects child has crashed. So if child calls DumpWithoutCrash and *doesn't* crash, then a subsequent real crash report won't be picked up. Unhandled java exception is actually not the problem here. The problem is all the other places in child processes that calls DumpWithoutCrash. Risk of breaking normal crash reports seems high to me, so reverting to be safe. Original issue's description: > android: Report java exception in child > > Enable JavaExceptionReporter for child processes so that unhandled java > exceptions generate crash reports. > > Note this also requires fixing InitNonBrowserCrashReporterForAndroid so > that SetDumpWithoutCrashingFunction is called in child processes. > > Tested with chrome://gpu-java-crash added in r447908, manually > enabling breakpad microdumps with local build, and adding > --enable-crash-reporter-for-testing. Verified microdump is generated > with the java stack information in logcat > > BUG=680775 > > Review-Url: https://codereview.chromium.org/2677563006 > Cr-Commit-Position: refs/heads/master@{#449000} > Committed: https://chromium.googlesource.com/chromium/src/+/e76f62c07f2dfbddef18d4011c576f678fc1f54b TBR=rsesek@chromium.org,mariakhomenko@chromium.org,grt@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=680775 Review-Url: https://codereview.chromium.org/2684893003 Cr-Commit-Position: refs/heads/master@{#449018} Committed: https://chromium.googlesource.com/chromium/src/+/16397c1b5df27f30968f55166048f14d4d80f0cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/app/chrome_main_delegate.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M components/crash/content/app/breakpad_linux.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
boliu
Created Revert of android: Report java exception in child
3 years, 10 months ago (2017-02-08 17:04:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684893003/1
3 years, 10 months ago (2017-02-08 17:05:06 UTC) #3
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 17:06:26 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/16397c1b5df27f30968f55166048...

Powered by Google App Engine
This is Rietveld 408576698