DescriptionRevert of android: Report java exception in child (patchset #2 id:20001 of https://codereview.chromium.org/2677563006/ )
Reason for revert:
tobiasjs@ pointed out:
DumpWithoutCrash doesn't really work on android in
child processes since android child processes sends
the dump through a FD, and browser only picks up
the FD after it detects child has crashed. So if
child calls DumpWithoutCrash and *doesn't* crash,
then a subsequent real crash report won't be picked
up.
Unhandled java exception is actually not the
problem here. The problem is all the other places
in child processes that calls DumpWithoutCrash.
Risk of breaking normal crash reports seems high
to me, so reverting to be safe.
Original issue's description:
> android: Report java exception in child
>
> Enable JavaExceptionReporter for child processes so that unhandled java
> exceptions generate crash reports.
>
> Note this also requires fixing InitNonBrowserCrashReporterForAndroid so
> that SetDumpWithoutCrashingFunction is called in child processes.
>
> Tested with chrome://gpu-java-crash added in r447908, manually
> enabling breakpad microdumps with local build, and adding
> --enable-crash-reporter-for-testing. Verified microdump is generated
> with the java stack information in logcat
>
> BUG=680775
>
> Review-Url: https://codereview.chromium.org/2677563006
> Cr-Commit-Position: refs/heads/master@{#449000}
> Committed: https://chromium.googlesource.com/chromium/src/+/e76f62c07f2dfbddef18d4011c576f678fc1f54b
TBR=rsesek@chromium.org,mariakhomenko@chromium.org,grt@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=680775
Review-Url: https://codereview.chromium.org/2684893003
Cr-Commit-Position: refs/heads/master@{#449018}
Committed: https://chromium.googlesource.com/chromium/src/+/16397c1b5df27f30968f55166048f14d4d80f0cd
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|