Avoid AddRef'ing non-thread-safe ref count on PageCaptureSaveAsMHTML

Avoid AddRef'ing non-thread-safe ref count on PageCaptureSaveAsMHTML

ShareableFileReference has non-thread-safe ref count, and is accessed
from multiple threads in PageCaptureSaveAsMHTML. That causes an DCHECK
failure on an upcoming change to RefCounted.
The failure in PageCaptureSaveAsHTMLFunction itself looks a false positive,
since all touching code are well ordered.

Review-Url: https://codereview.chromium.org/2684843004
Cr-Commit-Position: refs/heads/master@{#449400}
Committed: https://chromium.googlesource.com/chromium/src/+/e92ec6dc204912e3b5819b104414fc1e755e8b9d

[tzik, 2017-02-09 06:36:28]

The CQ bit was checked by tzik@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 06:37:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tzik, 2017-02-09 06:42:54]

Description was changed from

==========
Avoid to AddRef on non-thread-safe ref count on PageCaptureSaveAsMHTML
==========

to

==========
Avoid AddRef'ing non-thread-safe ref count on PageCaptureSaveAsMHTML
==========

[commit-bot: I haz the power, 2017-02-09 07:27:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 07:27:19]

Dry run: This issue passed the CQ dry run.

[tzik, 2017-02-09 07:35:13]

Description was changed from

==========
Avoid AddRef'ing non-thread-safe ref count on PageCaptureSaveAsMHTML
==========

to

==========
Avoid AddRef'ing non-thread-safe ref count on PageCaptureSaveAsMHTML

ShareableFileReference has non-thread-safe ref count, and is accessed
from multiple threads in PageCaptureSaveAsMHTML.
The usage in PageCaptureSaveAsHTMLFunction looks safe, since all touching
code are well ordered.
==========

[tzik, 2017-02-09 07:38:09]

Description was changed from

==========
Avoid AddRef'ing non-thread-safe ref count on PageCaptureSaveAsMHTML

ShareableFileReference has non-thread-safe ref count, and is accessed
from multiple threads in PageCaptureSaveAsMHTML.
The usage in PageCaptureSaveAsHTMLFunction looks safe, since all touching
code are well ordered.
==========

to

==========
Avoid AddRef'ing non-thread-safe ref count on PageCaptureSaveAsMHTML

ShareableFileReference has non-thread-safe ref count, and is accessed
from multiple threads in PageCaptureSaveAsMHTML. That causes an DCHECK
failure on an upcoming change to RefCounted.
The failure in PageCaptureSaveAsHTMLFunction itself looks a false positive,
since all touching code are well ordered.
==========

[tzik, 2017-02-09 07:42:56]

tzik@chromium.org changed reviewers:
+ rockot@chromium.org

[tzik, 2017-02-09 07:43:06]

PTAL

[Ken Rockot(use gerrit already), 2017-02-09 17:18:59]

lgtm

[tzik, 2017-02-09 20:41:41]

The CQ bit was checked by tzik@chromium.org

[commit-bot: I haz the power, 2017-02-09 20:42:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 20:47:16]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486672901834530, "parent_rev":
"cf6a9e83588feb2b05304d03543d3a0d10087dcc", "commit_rev":
"e92ec6dc204912e3b5819b104414fc1e755e8b9d"}

[commit-bot: I haz the power, 2017-02-09 20:48:03]

Description was changed from

==========
Avoid AddRef'ing non-thread-safe ref count on PageCaptureSaveAsMHTML

ShareableFileReference has non-thread-safe ref count, and is accessed
from multiple threads in PageCaptureSaveAsMHTML. That causes an DCHECK
failure on an upcoming change to RefCounted.
The failure in PageCaptureSaveAsHTMLFunction itself looks a false positive,
since all touching code are well ordered.
==========

to

==========
Avoid AddRef'ing non-thread-safe ref count on PageCaptureSaveAsMHTML

ShareableFileReference has non-thread-safe ref count, and is accessed
from multiple threads in PageCaptureSaveAsMHTML. That causes an DCHECK
failure on an upcoming change to RefCounted.
The failure in PageCaptureSaveAsHTMLFunction itself looks a false positive,
since all touching code are well ordered.

Review-Url: https://codereview.chromium.org/2684843004
Cr-Commit-Position: refs/heads/master@{#449400}
Committed:
https://chromium.googlesource.com/chromium/src/+/e92ec6dc204912e3b5819b104414...
==========

[commit-bot: I haz the power, 2017-02-09 20:48:05]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/e92ec6dc204912e3b5819b104414...