[WebAgent API]: Implement name style handling.

[WebAgent API]: Implement name style handling.

Since IDL names need to be represented in multiple different styles,
provide a single utility class for handling conversion, called
NameStyleConverter.

Start using this new utility class in templates.

R=bashi,yukishiino,haraken
BUG=683742
Review-Url: https://codereview.chromium.org/2684773003
Cr-Commit-Position: refs/heads/master@{#449291}
Committed: https://chromium.googlesource.com/chromium/src/+/e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574

[dglazkov, 2017-02-08 04:02:10]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 04:02:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 04:04:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 04:04:39]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[dglazkov, 2017-02-08 20:59:55]

Rebased.

[dglazkov, 2017-02-08 20:59:55]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 21:00:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 21:13:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 21:13:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[dglazkov, 2017-02-08 21:20:59]

Fixed the deps.

[dglazkov, 2017-02-08 21:21:00]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 21:21:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 23:54:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 23:54:40]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2017-02-08 23:56:08]

dglazkov@chromium.org changed reviewers:
+ yukishiino@chromium.org

[dglazkov, 2017-02-08 23:56:14]

PTAL.

[bashi, 2017-02-09 00:15:07]

This is great idea!

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/name_style_converter.py (right):

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:9:
SPECIAL_PREFIXES = [
Probably we should use v8_utilities.ACRONYMS (or move it here)?

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:63: 'macro':
self.to_macro_case(),
How about adding "_case" or "_style" prefix? When I see a following line, I
found it's a bit difficult to understand what it means.

template_context['class_name']['hacker']

Also, I'm not sure these terms are common.

[haraken, 2017-02-09 01:00:11]

LGTM

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py
(right):

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py:164:
self.generate_file(template_context, 'cc')

Is it intentional that you use .cc instead of .cpp?

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/name_style_converter.py (right):

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:1: #
Copyright 2016 The Chromium Authors. All rights reserved.

2017

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:18:
"""Detects special cases that aren not easily discernible without additional

are not

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:39: class
NameStyleConverter(object):

Add a comment and mention what hacker/pascal/macro case specifically means.

Nit: I feel that an "(lower-)camel" case is more common than a "pascal" case.

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:56: def
to_macro_case(self):

Where is the macro case used?

[dglazkov, 2017-02-09 04:11:34]

Feedback addressed.

[dglazkov, 2017-02-09 04:11:35]

The CQ bit was checked by dglazkov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 04:12:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dglazkov, 2017-02-09 04:15:29]

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py
(right):

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/code_generator_web_module.py:164:
self.generate_file(template_context, 'cc')
On 2017/02/09 at 01:00:11, haraken wrote:
> Is it intentional that you use .cc instead of .cpp?

Yep, trying to match the Chromium style for these classes.

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/name_style_converter.py (right):

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:1: #
Copyright 2016 The Chromium Authors. All rights reserved.
On 2017/02/09 at 01:00:11, haraken wrote:
> 2017

Ooops! Fixed.

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:9:
SPECIAL_PREFIXES = [
On 2017/02/09 at 00:15:07, bashi wrote:
> Probably we should use v8_utilities.ACRONYMS (or move it here)?

These are surprisingly intersecting, but not mutually inclusive sets. Looking at
IDL files, these two are the only ones I'd found where a simple regex couldn't
understand the extra semantics. Would you mind if I leave these as-is?

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:18:
"""Detects special cases that aren not easily discernible without additional
On 2017/02/09 at 01:00:11, haraken wrote:
> are not

Fixed.

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:39: class
NameStyleConverter(object):
On 2017/02/09 at 01:00:11, haraken wrote:
> Add a comment and mention what hacker/pascal/macro case specifically means.
> 
> Nit: I feel that an "(lower-)camel" case is more common than a "pascal" case.

Yep. Added comments and changed to snake_case/upper_camel_case/macro_case, with
Google C++ Style guide and Wikipedia references.

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:56: def
to_macro_case(self):
On 2017/02/09 at 01:00:11, haraken wrote:
> Where is the macro case used?

In the header guard.

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:63: 'macro':
self.to_macro_case(),
On 2017/02/09 at 00:15:07, bashi wrote:
> How about adding "_case" or "_style" prefix? When I see a following line, I
found it's a bit difficult to understand what it means.
> 
> template_context['class_name']['hacker']
> 
> Also, I'm not sure these terms are common.

Fixed.

[bashi, 2017-02-09 04:20:45]

lgtm

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/bindings/scripts/name_style_converter.py (right):

https://codereview.chromium.org/2684773003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/bindings/scripts/name_style_converter.py:9:
SPECIAL_PREFIXES = [
On 2017/02/09 04:15:29, dglazkov wrote:
> On 2017/02/09 at 00:15:07, bashi wrote:
> > Probably we should use v8_utilities.ACRONYMS (or move it here)?
> 
> These are surprisingly intersecting, but not mutually inclusive sets. Looking
at
> IDL files, these two are the only ones I'd found where a simple regex couldn't
> understand the extra semantics. Would you mind if I leave these as-is?

I see. I'm fine with this then :)

[commit-bot: I haz the power, 2017-02-09 06:20:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 06:20:45]

Dry run: This issue passed the CQ dry run.

[dglazkov, 2017-02-09 15:06:31]

The CQ bit was checked by dglazkov@chromium.org

[dglazkov, 2017-02-09 15:06:32]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2684773003/#ps60001
(title: "Feedback addressed.")

[commit-bot: I haz the power, 2017-02-09 15:06:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 15:11:25]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1486652791438430,
"parent_rev": "fd932ab936187fa497e6744b9a299755a7311af5", "commit_rev":
"e1eefe5f5757cf1c2c58f7bbdf0d4d2ea8031574"}

[commit-bot: I haz the power, 2017-02-09 15:12:02]

Description was changed from

==========
[WebAgent API]: Implement name style handling.

Since IDL names need to be represented in multiple different styles,
provide a single utility class for handling conversion, called
NameStyleConverter.

Start using this new utility class in templates.

R=bashi,yukishiino,haraken
BUG=683742
==========

to

==========
[WebAgent API]: Implement name style handling.

Since IDL names need to be represented in multiple different styles,
provide a single utility class for handling conversion, called
NameStyleConverter.

Start using this new utility class in templates.

R=bashi,yukishiino,haraken
BUG=683742

Review-Url: https://codereview.chromium.org/2684773003
Cr-Commit-Position: refs/heads/master@{#449291}
Committed:
https://chromium.googlesource.com/chromium/src/+/e1eefe5f5757cf1c2c58f7bbdf0d...
==========

[commit-bot: I haz the power, 2017-02-09 15:12:03]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/e1eefe5f5757cf1c2c58f7bbdf0d...