Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 2684753004: Make DisplayLinkMac RefCountedThreadSafe (Closed)

Created:
3 years, 10 months ago by tzik
Modified:
3 years, 10 months ago
Reviewers:
ccameron
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make DisplayLinkMac RefCountedThreadSafe DisplayLinkMac has a non-thread-safe ref count, but it's touched from both main thread and the display link thread. Review-Url: https://codereview.chromium.org/2684753004 Cr-Commit-Position: refs/heads/master@{#449839} Committed: https://chromium.googlesource.com/chromium/src/+/679a1c715691098c22285146381c520972d587b0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M ui/accelerated_widget_mac/display_link_mac.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
tzik
PTAL
3 years, 10 months ago (2017-02-09 12:02:30 UTC) #5
ccameron
lgtm
3 years, 10 months ago (2017-02-10 20:11:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684753004/1
3 years, 10 months ago (2017-02-11 03:00:40 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-11 03:42:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/679a1c715691098c22285146381c...

Powered by Google App Engine
This is Rietveld 408576698