Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2684753003: Added arc_metadata manifest entry & fileSystem permission dict (Closed)

Created:
3 years, 10 months ago by Ivan Šandrk
Modified:
3 years, 10 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Added arc_metadata manifest entry & fileSystem permission dict BUG=687672 Review-Url: https://codereview.chromium.org/2684753003 Cr-Commit-Position: refs/heads/master@{#448987} Committed: https://chromium.googlesource.com/chromium/src/+/933ddc2ee726091a7be2b1d2cb2a273231813313

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
Ivan Šandrk
Hi Drew, ptal! I've also whitelisted fileSystem permission dict because I've missed it the first ...
3 years, 10 months ago (2017-02-08 14:13:34 UTC) #4
Andrew T Wilson (Slow)
LGTM and we should request to merge back to M57.
3 years, 10 months ago (2017-02-08 14:15:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684753003/1
3 years, 10 months ago (2017-02-08 14:24:06 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 14:34:28 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/933ddc2ee726091a7be2b1d2cb2a...

Powered by Google App Engine
This is Rietveld 408576698