Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2684743003: [Sensors] start() and stop() methods do not throw (Closed)

Created:
3 years, 10 months ago by Mikhail
Modified:
3 years, 10 months ago
CC:
chromium-reviews, blink-reviews, wanming.lin, shalamov, Mikhail
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sensors] start() and stop() methods do not throw Instead, these methods should use "Handle Errors" operation (https://w3c.github.io/sensors/#handle-errors) for error handling consistency. BUG=606766 Review-Url: https://codereview.chromium.org/2684743003 Cr-Commit-Position: refs/heads/master@{#449247} Committed: https://chromium.googlesource.com/chromium/src/+/6848d8dc4042a49a4c614061a3fe466a29fa27c4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -9 lines) Patch
M third_party/WebKit/Source/modules/sensor/Sensor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/sensor/Sensor.idl View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Mikhail
PTAL
3 years, 10 months ago (2017-02-08 12:11:43 UTC) #4
shalamov
lgtm
3 years, 10 months ago (2017-02-08 13:06:31 UTC) #5
haraken
LGTM
3 years, 10 months ago (2017-02-08 18:08:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684743003/1
3 years, 10 months ago (2017-02-09 09:30:45 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/6848d8dc4042a49a4c614061a3fe466a29fa27c4
3 years, 10 months ago (2017-02-09 09:36:04 UTC) #13
Reilly Grant (use Gerrit)
3 years, 10 months ago (2017-02-10 18:21:04 UTC) #14
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698