Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Issue 2684723004: Enable presubmit lint check for ARC. (Closed)

Created:
3 years, 10 months ago by hidehiko
Modified:
3 years, 10 months ago
CC:
chromium-reviews, elijahtaylor+arcwatch_chromium.org, yusukes+watch_chromium.org, hidehiko+watch_chromium.org, lhchavez+watch_chromium.org, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable presubmit lint check for ARC. This CL enables presubmit check on uploading if the change is lint error free. BUG=689783 TEST=git cl presubmit --upload Review-Url: https://codereview.chromium.org/2684723004 Cr-Commit-Position: refs/heads/master@{#449245} Committed: https://chromium.googlesource.com/chromium/src/+/ef74850fa87ad5b31dc7d7953429dce12193ec49

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
A chrome/browser/chromeos/arc/PRESUBMIT.py View 1 chunk +6 lines, -0 lines 0 comments Download
A components/arc/PRESUBMIT.py View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
hidehiko
PTAL.
3 years, 10 months ago (2017-02-08 14:51:57 UTC) #6
Luis Héctor Chávez
lgtm woo, thanks!
3 years, 10 months ago (2017-02-08 16:07:58 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684723004/1
3 years, 10 months ago (2017-02-08 16:08:15 UTC) #9
Luis Héctor Chávez
sorry, tapped on the wrong button and accidentally CQ'd it.
3 years, 10 months ago (2017-02-08 16:09:41 UTC) #11
Yusuke Sato
lgtm
3 years, 10 months ago (2017-02-08 16:12:41 UTC) #12
hidehiko
Thank you for review. Verified no lint error on ToT right now, again. Landing.
3 years, 10 months ago (2017-02-09 09:23:36 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684723004/1
3 years, 10 months ago (2017-02-09 09:23:56 UTC) #15
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 09:28:50 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/ef74850fa87ad5b31dc7d7953429...

Powered by Google App Engine
This is Rietveld 408576698