Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2684693005: [Error Pages] Remove unused strings from components (Closed)

Created:
3 years, 10 months ago by Mathieu
Modified:
3 years, 10 months ago
Reviewers:
Julia Tuttle
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Error Pages] Remove unused strings from components BUG=690075 TEST=builds Review-Url: https://codereview.chromium.org/2684693005 Cr-Commit-Position: refs/heads/master@{#449306} Committed: https://chromium.googlesource.com/chromium/src/+/c6d85d0cea9a4b4921db5ffb64e82fc809f6468d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -24 lines) Patch
M components/error_page_strings.grdp View 5 chunks +0 lines, -24 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Mathieu
Hi Julia, PTAL!
3 years, 10 months ago (2017-02-09 02:11:26 UTC) #6
Julia Tuttle
On 2017/02/09 02:11:26, Mathieu Perreault wrote: > Hi Julia, PTAL! lgtm.
3 years, 10 months ago (2017-02-09 16:00:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684693005/1
3 years, 10 months ago (2017-02-09 16:07:52 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 16:13:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c6d85d0cea9a4b4921db5ffb64e8...

Powered by Google App Engine
This is Rietveld 408576698