Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issue 2684683002: Explain requirements on fields accessed from generated code. (Closed)

Created:
3 years, 10 months ago by rmacnak
Modified:
3 years, 10 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Explain requirements on fields accessed from generated code. R=fschneider@google.com Committed: https://github.com/dart-lang/sdk/commit/a0fe1a2f8953f3e00c4c52117683f0d2fa37bf6f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -4 lines) Patch
M runtime/vm/isolate.h View 1 chunk +6 lines, -1 line 0 comments Download
M runtime/vm/scavenger.h View 1 chunk +6 lines, -2 lines 0 comments Download
M runtime/vm/thread.h View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
rmacnak
3 years, 10 months ago (2017-02-07 18:18:26 UTC) #2
Florian Schneider
lgtm
3 years, 10 months ago (2017-02-07 18:21:34 UTC) #3
rmacnak
3 years, 10 months ago (2017-02-07 19:27:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a0fe1a2f8953f3e00c4c52117683f0d2fa37bf6f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698