Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Unified Diff: runtime/vm/isolate.h

Issue 2684683002: Explain requirements on fields accessed from generated code. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/scavenger.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/isolate.h
diff --git a/runtime/vm/isolate.h b/runtime/vm/isolate.h
index fe4da0816b631baf11c72e5d160b79d90f7e5853..4180ccee69cd841cc4e768be90334f7ae629d26f 100644
--- a/runtime/vm/isolate.h
+++ b/runtime/vm/isolate.h
@@ -696,7 +696,12 @@ class Isolate : public BaseIsolate {
return mutator_thread()->zone();
}
- // Accessed from generated code:
+ // Accessed from generated code.
+ // ** This block of fields must come first! **
+ // For AOT cross-compilation, we rely on these members having the same offsets
+ // in SIMARM(IA32) and ARM, and the same offsets in SIMARM64(X64) and ARM64.
+ // We use only word-sized fields to avoid differences in struct packing on the
+ // different architectures. See also CheckOffsets in dart.cc.
StoreBuffer* store_buffer_;
Heap* heap_;
uword user_tag_;
« no previous file with comments | « no previous file | runtime/vm/scavenger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698