Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 2684643002: Convert ContentSettingBubbleWebContentsObserverBridge to use the new navigation callbacks. (Closed)

Created:
3 years, 10 months ago by jam
Modified:
3 years, 10 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, mac-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ContentSettingBubbleWebContentsObserverBridge to use the new navigation callbacks. BUG=682002 Review-Url: https://codereview.chromium.org/2684643002 Cr-Commit-Position: refs/heads/master@{#448660} Committed: https://chromium.googlesource.com/chromium/src/+/3b4fa7b06432f4af1b6f5baacc107b10f8338673

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm View 2 chunks +7 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
jam
3 years, 10 months ago (2017-02-07 17:19:46 UTC) #7
Avi (use Gerrit)
lgtm
3 years, 10 months ago (2017-02-07 17:30:11 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684643002/1
3 years, 10 months ago (2017-02-07 17:42:14 UTC) #10
commit-bot: I haz the power
3 years, 10 months ago (2017-02-07 17:46:58 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3b4fa7b06432f4af1b6f5baacc10...

Powered by Google App Engine
This is Rietveld 408576698