Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1227)

Unified Diff: third_party/WebKit/Source/platform/heap/VisitorImpl.h

Issue 2684633004: Remove orphaned pages from Oilpan (Closed)
Patch Set: temp Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/heap/TraceTraits.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/heap/VisitorImpl.h
diff --git a/third_party/WebKit/Source/platform/heap/VisitorImpl.h b/third_party/WebKit/Source/platform/heap/VisitorImpl.h
index f2e90e00bfc7f4be09a74bc76448f26a6c59de66..ec0b537f405f2244a64577f6fbf70db3f19d52ad 100644
--- a/third_party/WebKit/Source/platform/heap/VisitorImpl.h
+++ b/third_party/WebKit/Source/platform/heap/VisitorImpl.h
@@ -18,14 +18,6 @@ inline void Visitor::markHeader(HeapObjectHeader* header,
DCHECK(header);
DCHECK(objectPointer);
- // If you hit this DCHECK, it means that there is a dangling pointer
- // from a live thread heap to a dead thread heap. We must eliminate
- // the dangling pointer.
- // Release builds don't have the DCHECK, but it is OK because
- // release builds will crash in the following header->isMarked()
- // because all the entries of the orphaned arenas are zapped.
- DCHECK(!pageFromObject(objectPointer)->orphaned());
-
if (header->isMarked())
return;
« no previous file with comments | « third_party/WebKit/Source/platform/heap/TraceTraits.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698