Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Unified Diff: third_party/WebKit/Source/platform/heap/TraceTraits.h

Issue 2684633004: Remove orphaned pages from Oilpan (Closed)
Patch Set: temp Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/heap/TraceTraits.h
diff --git a/third_party/WebKit/Source/platform/heap/TraceTraits.h b/third_party/WebKit/Source/platform/heap/TraceTraits.h
index fb5b1a0c01570df61e788b209b316c57da4f45fa..544e76248151a10cffb4f0f6fa8f2671a2f7f367 100644
--- a/third_party/WebKit/Source/platform/heap/TraceTraits.h
+++ b/third_party/WebKit/Source/platform/heap/TraceTraits.h
@@ -108,15 +108,6 @@ class AdjustAndMarkTrait<T, true> {
static void mark(VisitorDispatcher visitor, const T* self) {
if (!self)
return;
-
- // If you hit this ASSERT, it means that there is a dangling pointer
- // from a live thread heap to a dead thread heap. We must eliminate
- // the dangling pointer.
- // Release builds don't have the ASSERT, but it is OK because
- // release builds will crash at the following self->adjustAndMark
- // because all the entries of the orphaned arenas are zeroed out and
- // thus the item does not have a valid vtable.
- ASSERT(!pageFromObject(self)->orphaned());
self->adjustAndMark(visitor);
}
};
« no previous file with comments | « third_party/WebKit/Source/platform/heap/ThreadState.cpp ('k') | third_party/WebKit/Source/platform/heap/VisitorImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698