Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issue 2684593007: Merged: [turbofan] Fix representation change from bit to tagged pointer. (Closed)

Created:
3 years, 10 months ago by Jarin
Modified:
3 years, 10 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com, v8-merges_googlegroups.com, ulan
Target Ref:
refs/pending/branch-heads/5.6
Project:
v8
Visibility:
Public.

Description

Merged: [turbofan] Fix representation change from bit to tagged pointer. Revision: d024df4d22eb69904bfd29c7716ff0f2c16f5d18 BUG=chromium:673244 LOG=N NOTRY=true NOPRESUBMIT=true NOTREECHECKS=true R=bmeurer@chromium.org TBR=bmeurer@chromium.org Review-Url: https://codereview.chromium.org/2684593007 . Cr-Commit-Position: refs/branch-heads/5.6@{#112} Cr-Branched-From: bdd3886218dfe76e8560eb8a18401942452ae859-refs/heads/5.6.326@{#1} Cr-Branched-From: 879f6599eee6e1dfcbe9a24bf688b261c03e9558-refs/heads/master@{#41014} Committed: https://chromium.googlesource.com/v8/v8/+/bd54aa2c9039a141b09d2456f8d7297ae3f5baf8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M src/compiler/representation-change.cc View 1 chunk +6 lines, -1 line 0 comments Download
A test/mjsunit/compiler/regress-673244.js View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jarin
3 years, 10 months ago (2017-02-09 11:43:03 UTC) #1
Jarin
NOTE: This script will no longer automatically update include/v8-version.h and create a tag. This is ...
3 years, 10 months ago (2017-02-09 11:43:04 UTC) #2
Benedikt Meurer
LGTM
3 years, 10 months ago (2017-02-09 12:14:58 UTC) #4
Jarin
3 years, 10 months ago (2017-02-09 12:16:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
bd54aa2c9039a141b09d2456f8d7297ae3f5baf8.

Powered by Google App Engine
This is Rietveld 408576698