Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(702)

Unified Diff: chrome/browser/permissions/permission_blacklist_client.cc

Issue 2684523002: Check result of ApiBlacklist query in client. (Closed)
Patch Set: Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/permissions/permission_blacklist_client.cc
diff --git a/chrome/browser/permissions/permission_blacklist_client.cc b/chrome/browser/permissions/permission_blacklist_client.cc
index ef0be9b38574c4b4515a9923c5d5666b2d5ff6c4..24c616c8e853e16c286e409b46dd5711bdaedffe 100644
--- a/chrome/browser/permissions/permission_blacklist_client.cc
+++ b/chrome/browser/permissions/permission_blacklist_client.cc
@@ -61,7 +61,11 @@ void PermissionBlacklistClient::StartCheck(const GURL& request_origin) {
FROM_HERE, base::TimeDelta::FromMilliseconds(timeout_),
base::Bind(&PermissionBlacklistClient::OnCheckApiBlacklistUrlResult, this,
request_origin, empty_metadata));
- db_manager_->CheckApiBlacklistUrl(request_origin, this);
+
+ // If CheckApiBlacklistUrl returns true, no asynchronous call to |this| will
+ // be made, so just directly call through to OnCheckApiBlacklistUrlResult.
+ if (db_manager_->CheckApiBlacklistUrl(request_origin, this))
+ this->OnCheckApiBlacklistUrlResult(request_origin, empty_metadata);
dominickn 2017/02/07 08:27:06 Nit: no need for this->
meredithl 2017/02/08 00:58:03 Done.
}
void PermissionBlacklistClient::OnCheckApiBlacklistUrlResult(
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698