Check result of ApiBlacklist query in client.

chrome/browser/permissions/permission_blacklist_client.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_blacklist_client.h"
 
 #include <set>
 #include <string>
 
 #include "base/logging.h"
@@ skipping 43 matching lines @@
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
 
   // Start the timer to interrupt into the client callback method with an
   // empty response if Safe Browsing times out.
   safe_browsing::ThreatMetadata empty_metadata;
   timer_ = base::MakeUnique<base::OneShotTimer>();
   timer_->Start(
       FROM_HERE, base::TimeDelta::FromMilliseconds(timeout_),
       base::Bind(&PermissionBlacklistClient::OnCheckApiBlacklistUrlResult, this,
                  request_origin, empty_metadata));
-  db_manager_->CheckApiBlacklistUrl(request_origin, this);
+
+  // If CheckApiBlacklistUrl returns true, no asynchronous call to |this| will
+  // be made, so just directly call through to OnCheckApiBlacklistUrlResult.
+  if (db_manager_->CheckApiBlacklistUrl(request_origin, this))
+    this->OnCheckApiBlacklistUrlResult(request_origin, empty_metadata);

[dominickn, 2017/02/07 08:27:06]

Nit: no need for this->

[meredithl, 2017/02/08 00:58:03]

Done.

 }
 
 void PermissionBlacklistClient::OnCheckApiBlacklistUrlResult(
     const GURL& url,
     const safe_browsing::ThreatMetadata& metadata) {
   DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
 
   if (timer_->IsRunning())
     timer_->Stop();
   else
@@ skipping 17 matching lines @@
 
   if (is_active_)
     callback_.Run(permission_blocked);
   Release();
 }
 
 void PermissionBlacklistClient::WebContentsDestroyed() {
   is_active_ = false;
   Observe(nullptr);
 }