Ensure StyleSheetInsert-bootstrap.html doesn't spam willInsertBody IPCs

Ensure StyleSheetInsert-bootstrap.html doesn't spam willInsertBody IPCs

A recent change to support ResourceScheduler in OOPIF mode [1] caused
a regression on this benchmark. The reason is that this benchmark
Essentially creates an empty iframe, populates it, and empties it again
in a tight loop.

This triggers us to send a WillInsertBody IPC for every loop iteration,
adding a lot of overhead to the benchmark.

As this idiom is likely not representative, this patch modifies the
benchmark to instead just insert and remove the style node in a tight
loop.

[1] https://codereview.chromium.org/2655393004

BUG=689190
Review-Url: https://codereview.chromium.org/2684483002
Cr-Commit-Position: refs/heads/master@{#448621}
Committed: https://chromium.googlesource.com/chromium/src/+/d68b4a106ecc41b8b16079a30ac422ad571554ed

[Charlie Harrison, 2017-02-07 00:52:55]

The CQ bit was checked by csharrison@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-07 00:54:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Harrison, 2017-02-07 00:54:58]

csharrison@chromium.org changed reviewers:
+ pmeenan@chromium.org

[Charlie Harrison, 2017-02-07 00:54:59]

Hey Pat, would you review this?

Please take a look at the linked issue to see why this is happening.
Essentially, we now send this IPC for subframes as well as main frames.

[commit-bot: I haz the power, 2017-02-07 02:19:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-07 02:19:40]

Dry run: This issue passed the CQ dry run.

[Pat Meenan, 2017-02-07 13:47:10]

On 2017/02/07 00:54:59, Charlie Harrison wrote:
> Hey Pat, would you review this?
> 
> Please take a look at the linked issue to see why this is happening.
> Essentially, we now send this IPC for subframes as well as main frames.

LGTM

At some point we'll also need to fix it to not use sync XHR to fetch the sheet
text (whenever support is finally killed).

[Charlie Harrison, 2017-02-07 14:26:47]

The CQ bit was checked by csharrison@chromium.org

[commit-bot: I haz the power, 2017-02-07 14:26:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-07 14:30:55]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1486477607612580, "parent_rev":
"e1e28b7083de3578e162dba88a439f5654f50c37", "commit_rev":
"d68b4a106ecc41b8b16079a30ac422ad571554ed"}

[commit-bot: I haz the power, 2017-02-07 14:31:29]

Description was changed from

==========
Ensure StyleSheetInsert-bootstrap.html doesn't spam willInsertBody IPCs

A recent change to support ResourceScheduler in OOPIF mode [1] caused
a regression on this benchmark. The reason is that this benchmark
Essentially creates an empty iframe, populates it, and empties it again
in a tight loop.

This triggers us to send a WillInsertBody IPC for every loop iteration,
adding a lot of overhead to the benchmark.

As this idiom is likely not representative, this patch modifies the
benchmark to instead just insert and remove the style node in a tight
loop.

[1] https://codereview.chromium.org/2655393004

BUG=689190
==========

to

==========
Ensure StyleSheetInsert-bootstrap.html doesn't spam willInsertBody IPCs

A recent change to support ResourceScheduler in OOPIF mode [1] caused
a regression on this benchmark. The reason is that this benchmark
Essentially creates an empty iframe, populates it, and empties it again
in a tight loop.

This triggers us to send a WillInsertBody IPC for every loop iteration,
adding a lot of overhead to the benchmark.

As this idiom is likely not representative, this patch modifies the
benchmark to instead just insert and remove the style node in a tight
loop.

[1] https://codereview.chromium.org/2655393004

BUG=689190

Review-Url: https://codereview.chromium.org/2684483002
Cr-Commit-Position: refs/heads/master@{#448621}
Committed:
https://chromium.googlesource.com/chromium/src/+/d68b4a106ecc41b8b16079a30ac4...
==========

[commit-bot: I haz the power, 2017-02-07 14:31:30]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d68b4a106ecc41b8b16079a30ac4...