Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: services/catalog/BUILD.gn

Issue 2684433003: Files required by a service now listed in manifest. (Closed)
Patch Set: Fixed analysis. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/catalog/BUILD.gn
diff --git a/services/catalog/BUILD.gn b/services/catalog/BUILD.gn
index fe2f22dce3d35e170b6e39a8bf3a8c1fd4c7a575..ea3b526c6716d4808e6b984761abbb40c67831ab 100644
--- a/services/catalog/BUILD.gn
+++ b/services/catalog/BUILD.gn
@@ -13,6 +13,13 @@ group("catalog") {
]
}
+source_set("constants_lib") {
Ken Rockot(use gerrit already) 2017/02/09 17:17:28 nit: How about just "constants"? The "lib" patter
Jay Civelli 2017/02/09 22:08:27 Done.
+ sources = [
+ "store.cc",
+ "store.h",
+ ]
+}
+
source_set("lib") {
sources = [
"catalog.cc",
@@ -26,13 +33,13 @@ source_set("lib") {
"instance.cc",
"instance.h",
"manifest_provider.h",
- "store.cc",
- "store.h",
]
deps = [
+ ":constants_lib",
"//base",
"//components/filesystem:lib",
+ "//services/catalog/public/cpp",
"//services/catalog/public/interfaces",
"//services/service_manager/public/cpp",
]

Powered by Google App Engine
This is Rietveld 408576698