Files required by a service now listed in manifest.

services/catalog/BUILD.gn

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//services/service_manager/public/cpp/service.gni")
 import("//services/service_manager/public/service_manifest.gni")
 import("//testing/test.gni")
 
 group("catalog") {
   testonly = true
   deps = [
     ":lib",
   ]
 }
 
+source_set("constants_lib") {

[Ken Rockot(use gerrit already), 2017/02/09 17:17:28]

nit: How about just "constants"?  The "lib" pattern is generally just used to
separate service impl code from the actual standalone service output target so
we can link services into other targets.

[Jay Civelli, 2017/02/09 22:08:27]

Done.

+  sources = [
+    "store.cc",
+    "store.h",
+  ]
+}
+
 source_set("lib") {
   sources = [
     "catalog.cc",
     "catalog.h",
     "constants.cc",
     "constants.h",
     "entry.cc",
     "entry.h",
     "entry_cache.cc",
     "entry_cache.h",
     "instance.cc",
     "instance.h",
     "manifest_provider.h",
-    "store.cc",
-    "store.h",
   ]
 
   deps = [
+    ":constants_lib",
     "//base",
     "//components/filesystem:lib",
+    "//services/catalog/public/cpp",
     "//services/catalog/public/interfaces",
     "//services/service_manager/public/cpp",
   ]
 
   public_deps = [
     # directory.mojom.h is #included by catalog.h
     "//components/filesystem/public/interfaces",
   ]
 }
 
@@ skipping 10 matching lines @@
   data = [
     "//services/catalog/data/",
   ]
   deps = [
     ":lib",
     "//base",
     "//services/service_manager/public/cpp",
     "//testing/gtest",
   ]
 }