Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2684373002: Enable opening http://localhost WebAPK in WebAPK mode (Closed)

Created:
3 years, 10 months ago by pkotwicz
Modified:
3 years, 10 months ago
Reviewers:
dominickn
CC:
chromium-reviews, zpeng+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable opening http://localhost WebAPK in WebAPK mode Chrome launches WebAPKs in WebAPK mode only if they are valid WebAPKs. One of the validity requirements is that the WebAPK's start URL be within the scope of the WebAPK's intent filter. This CL makes the intent filter's scheme customizable by the WebAPK server. BUG=655438 Review-Url: https://codereview.chromium.org/2684373002 Cr-Commit-Position: refs/heads/master@{#449635} Committed: https://chromium.googlesource.com/chromium/src/+/91697d2c952534944300a1dee86a90d135c736a1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M chrome/android/webapk/shell_apk/AndroidManifest.xml View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/webapk/shell_apk/BUILD.gn View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
pkotwicz
Dominick, can you please take a look?
3 years, 10 months ago (2017-02-10 01:45:39 UTC) #4
dominickn
lgtm
3 years, 10 months ago (2017-02-10 03:01:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684373002/1
3 years, 10 months ago (2017-02-10 15:35:49 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 16:52:28 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/91697d2c952534944300a1dee86a...

Powered by Google App Engine
This is Rietveld 408576698