Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 2684343003: Revert of Fixed title updating for back forward navigation. (Closed)

Created:
3 years, 10 months ago by stkhapugin
Modified:
3 years, 10 months ago
CC:
chromium-reviews, marq+watch_chromium.org, Eugene But (OOO till 7-30), pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org, rohitrao (ping after 24h)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Fixed title updating for back forward navigation. (patchset #3 id:40001 of https://codereview.chromium.org/2685803002/ ) Reason for revert: Breaks -[TabHistoryPopupControllerTestCase testTabHistoryMenu] tab_history_popup_controller_egtest.mm downstream, because New Tab in history popup (when long pressed on back) displays "chrome://newtab" instead of "New Tab". I actually don't know why this test is not ran upstream, but I have to revert, sorry! Original issue's description: > Fixed title updating for back forward navigation. > > Chrome relies on KVO compliant "title" property to subscribe for > title updates. If this KVO change happens during then navigation > it is unclear if title was changes for the previous page, or the > navigation was committed and title was changed for the new page. > > So if there is a navigation in progress WebController should ignore > KVO change, but it should always attempt to update title when > navigation is committed. > > BUG=688047, 677356 > > Review-Url: https://codereview.chromium.org/2685803002 > Cr-Commit-Position: refs/heads/master@{#449527} > Committed: https://chromium.googlesource.com/chromium/src/+/487e4cfd53bac5944dad49cbce3b939a0c7bf035 TBR=kkhorimoto@chromium.org,eugenebut@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=688047, 677356 Review-Url: https://codereview.chromium.org/2684343003 Cr-Commit-Position: refs/heads/master@{#449595} Committed: https://chromium.googlesource.com/chromium/src/+/69378e0417fa4dbcae4dc863e5b46b68d71ac0be

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -60 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 3 chunks +25 lines, -2 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 chunk +0 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 4 chunks +6 lines, -34 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states.h View 1 chunk +0 lines, -4 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states.mm View 1 chunk +0 lines, -9 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
stkhapugin
Created Revert of Fixed title updating for back forward navigation.
3 years, 10 months ago (2017-02-10 12:09:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684343003/1
3 years, 10 months ago (2017-02-10 12:09:21 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/69378e0417fa4dbcae4dc863e5b46b68d71ac0be
3 years, 10 months ago (2017-02-10 12:10:44 UTC) #7
Eugene But (OOO till 7-30)
3 years, 10 months ago (2017-02-10 18:27:06 UTC) #8
Message was sent while issue was closed.
lgtm Sorry for breaking this

Powered by Google App Engine
This is Rietveld 408576698