Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(607)

Issue 2684313004: Additional cleanup of pre-md system menu user row code. (Closed)

Created:
3 years, 10 months ago by Evan Stade
Modified:
3 years, 10 months ago
Reviewers:
tdanderson, oshima
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Additional cleanup of pre-md system menu user row code. TBR=oshima@chromium.org BUG=686294 Review-Url: https://codereview.chromium.org/2684313004 Cr-Commit-Position: refs/heads/master@{#450047} Committed: https://chromium.googlesource.com/chromium/src/+/958320943013f5cbe97fb80a19a05f27b6ca4119

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -382 lines) Patch
M ash/BUILD.gn View 2 chunks +0 lines, -5 lines 0 comments Download
D ash/common/popup_message.h View 1 chunk +0 lines, -82 lines 0 comments Download
D ash/common/popup_message.cc View 1 chunk +0 lines, -233 lines 0 comments Download
D ash/common/popup_message_unittest.cc View 1 chunk +0 lines, -51 lines 0 comments Download
M ash/common/system/user/user_view.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/common/system/user/user_view.cc View 5 chunks +4 lines, -7 lines 0 comments Download
M ash/resources/ash_resources.grd View 1 chunk +0 lines, -2 lines 0 comments Download
D ash/resources/default_100_percent/common/alert_small.png View Binary file 0 comments Download
D ash/resources/default_200_percent/common/alert_small.png View Binary file 0 comments Download

Messages

Total messages: 15 (8 generated)
Evan Stade
3 years, 10 months ago (2017-02-11 00:05:59 UTC) #2
tdanderson
LGTM
3 years, 10 months ago (2017-02-13 16:56:14 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684313004/1
3 years, 10 months ago (2017-02-13 17:14:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/362857)
3 years, 10 months ago (2017-02-13 17:21:31 UTC) #7
Evan Stade
+oshima TBR for asset removal
3 years, 10 months ago (2017-02-13 19:36:17 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684313004/1
3 years, 10 months ago (2017-02-13 19:37:20 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 19:48:46 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/958320943013f5cbe97fb80a19a0...

Powered by Google App Engine
This is Rietveld 408576698