Allow ScopedTaskScheduler to be created before a class that overrides MessageLoop::current()'s task…

Allow ScopedTaskScheduler to be created before a class that overrides MessageLoop::current() such as ScopedMockTimeMessageLoopTaskRunner.

BUG=690504
Review-Url: https://codereview.chromium.org/2684273002
Cr-Commit-Position: refs/heads/master@{#450981}
Committed: https://chromium.googlesource.com/chromium/src/+/74b6455bacd6648d765d251d486b2e5cfba60eb1

[Joe Mason, 2017-02-09 16:23:37]

Description was changed from

==========
Allow ScopedTaskScheduler to be created before a class that overrides
MessageLoop::current()'s task runner such as
ScopedMockTimeMessageLoopTaskRunner.

BUG=690504
==========

to

==========
Allow ScopedTaskScheduler to be created before a class that overrides
MessageLoop::current() such as ScopedMockTimeMessageLoopTaskRunner.

BUG=690504
==========

[Joe Mason, 2017-02-09 16:24:49]

joenotcharles@chromium.org changed reviewers:
+ fdoray@chromium.org

[Joe Mason, 2017-02-09 16:24:50]

ptal

[Joe Mason, 2017-02-09 19:04:34]

The CQ bit was checked by joenotcharles@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 19:05:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 20:56:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 20:56:34]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[fdoray, 2017-02-10 12:39:59]

lgtm. Thanks!

[Joe Mason, 2017-02-15 21:36:00]

The CQ bit was checked by joenotcharles@chromium.org

[commit-bot: I haz the power, 2017-02-15 21:37:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 23:04:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 23:04:36]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[Joe Mason, 2017-02-16 03:26:22]

The CQ bit was checked by joenotcharles@chromium.org

[commit-bot: I haz the power, 2017-02-16 03:27:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 05:29:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-16 05:29:44]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)

[Joe Mason, 2017-02-16 16:08:18]

The CQ bit was checked by joenotcharles@chromium.org

[commit-bot: I haz the power, 2017-02-16 16:08:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-16 16:14:09]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1487261298212190,
"parent_rev": "d0261c37e9385b97dbc34fc04fbde774f6be4fa7", "commit_rev":
"74b6455bacd6648d765d251d486b2e5cfba60eb1"}

[commit-bot: I haz the power, 2017-02-16 16:14:52]

Description was changed from

==========
Allow ScopedTaskScheduler to be created before a class that overrides
MessageLoop::current() such as ScopedMockTimeMessageLoopTaskRunner.

BUG=690504
==========

to

==========
Allow ScopedTaskScheduler to be created before a class that overrides
MessageLoop::current() such as ScopedMockTimeMessageLoopTaskRunner.

BUG=690504

Review-Url: https://codereview.chromium.org/2684273002
Cr-Commit-Position: refs/heads/master@{#450981}
Committed:
https://chromium.googlesource.com/chromium/src/+/74b6455bacd6648d765d251d486b...
==========

[commit-bot: I haz the power, 2017-02-16 16:14:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/74b6455bacd6648d765d251d486b...

[Roger McFarlane (Chromium), 2017-02-21 21:31:42]

rogerm@chromium.org changed reviewers:
+ rogerm@chromium.org

[Roger McFarlane (Chromium), 2017-02-21 21:31:43]

This change seems to break https://codereview.chromium.org/2565873002/

I'm not sure what I need to do to get this to play nicely with
net::FakeURLFetcherFactory.

[Joe Mason, 2017-02-21 23:20:14]

On 2017/02/21 21:31:43, Roger McFarlane (Chromium) wrote:
> This change seems to break https://codereview.chromium.org/2565873002/
> 
> I'm not sure what I need to do to get this to play nicely with
> net::FakeURLFetcherFactory.

Found the problem. Working on a fix.

[Joe Mason, 2017-02-21 23:54:22]

On 2017/02/21 23:20:14, Joe Mason wrote:
> On 2017/02/21 21:31:43, Roger McFarlane (Chromium) wrote:
> > This change seems to break https://codereview.chromium.org/2565873002/
> > 
> > I'm not sure what I need to do to get this to play nicely with
> > net::FakeURLFetcherFactory.
> 
> Found the problem. Working on a fix.

Fix is at https://codereview.chromium.org/2713513003/