Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2684243003: Settings: Change the cr-network-list-item height to min-height (Closed)

Created:
3 years, 10 months ago by stevenjb
Modified:
3 years, 10 months ago
Reviewers:
michaelpg
CC:
chromium-reviews, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org, dbeam+watch-elements_chromium.org, oshima+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Settings: Change the cr-network-list-item height to min-height This fixes a lyaout bug for very large fonts BUG=689958 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2684243003 Cr-Commit-Position: refs/heads/master@{#450097} Committed: https://chromium.googlesource.com/chromium/src/+/a2665e010b198f117ab5bc9fcf60f7aa02b92f67

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M ui/webui/resources/cr_elements/network/cr_network_list_item.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (5 generated)
stevenjb
3 years, 10 months ago (2017-02-10 01:08:54 UTC) #3
michaelpg
lgtm
3 years, 10 months ago (2017-02-13 19:30:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684243003/1
3 years, 10 months ago (2017-02-13 19:41:33 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-13 21:29:14 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2665e010b198f117ab5bc9fcf60...

Powered by Google App Engine
This is Rietveld 408576698