Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 2684233004: [heap] Remove dead counters and move regexp code counter to Isolate (Closed)

Created:
3 years, 10 months ago by Michael Lippautz
Modified:
3 years, 10 months ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Remove dead counters and move regexp code counter to Isolate BUG= Review-Url: https://codereview.chromium.org/2684233004 Cr-Commit-Position: refs/heads/master@{#43094} Committed: https://chromium.googlesource.com/v8/v8/+/e03a220611bcff9ed294bcc940bbb5b0c6f7f386

Patch Set 1 #

Patch Set 2 : Fix compilation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -34 lines) Patch
M src/codegen.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/heap.h View 1 3 chunks +0 lines, -20 lines 0 comments Download
M src/heap/heap.cc View 1 2 chunks +0 lines, -3 lines 0 comments Download
M src/isolate.h View 2 chunks +7 lines, -0 lines 0 comments Download
M src/isolate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/regexp/jsregexp.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/regexp/jsregexp.cc View 1 3 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 24 (16 generated)
Michael Lippautz
3 years, 10 months ago (2017-02-10 09:03:06 UTC) #5
Hannes Payer (out of office)
lgtm
3 years, 10 months ago (2017-02-10 11:47:30 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684233004/20001
3 years, 10 months ago (2017-02-10 11:55:31 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on master.tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/34446)
3 years, 10 months ago (2017-02-10 11:58:21 UTC) #16
Michael Lippautz
+jgrubger: for regexp
3 years, 10 months ago (2017-02-10 12:03:01 UTC) #18
jgruber
lgtm, only looked at regexp/
3 years, 10 months ago (2017-02-10 12:29:56 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684233004/20001
3 years, 10 months ago (2017-02-10 12:30:24 UTC) #21
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 12:32:06 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/e03a220611bcff9ed294bcc940bbb5b0c6f...

Powered by Google App Engine
This is Rietveld 408576698