Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 2684193005: MD Settings: Internet: Request network scan (Closed)

Created:
3 years, 10 months ago by stevenjb
Modified:
3 years, 10 months ago
Reviewers:
Alexander Alekseev
CC:
chromium-reviews, dbeam+watch-elements_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, dbeam+watch-settings_chromium.org, michaelpg+watch-elements_chromium.org, stevenjb+watch-md-settings_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Internet: Request network scan at regular intervals This adds network scan requests every 10s to the Settings and OOBE pages. BUG=687673 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2684193005 Cr-Commit-Position: refs/heads/master@{#449753} Committed: https://chromium.googlesource.com/chromium/src/+/c010a4d03a91256d1b514fae3d710acffe46db30

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -4 lines) Patch
M chrome/browser/resources/settings/internet_page/network_summary.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary.js View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary_item.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/internet_page/network_summary_item.js View 1 3 chunks +40 lines, -0 lines 0 comments Download
M ui/webui/resources/cr_elements/network/cr_network_select.js View 3 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 11 (7 generated)
stevenjb
3 years, 10 months ago (2017-02-10 20:09:58 UTC) #3
Alexander Alekseev
lgtm
3 years, 10 months ago (2017-02-10 20:17:01 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684193005/20001
3 years, 10 months ago (2017-02-10 20:42:28 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-10 22:12:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/c010a4d03a91256d1b514fae3d71...

Powered by Google App Engine
This is Rietveld 408576698