Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2684193003: [turbofan] Add support for %_MaxSmi and %_TypedArrayMaxSizeInHeap. (Closed)

Created:
3 years, 10 months ago by Benedikt Meurer
Modified:
3 years, 10 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add support for %_MaxSmi and %_TypedArrayMaxSizeInHeap. These intrinsics are heavily used in typedarray.js and are part of the reason why the typed array constructors are more than twice as slow in TurboFan compared to Crankshaft. R=jarin@chromium.org Review-Url: https://codereview.chromium.org/2684193003 Cr-Commit-Position: refs/heads/master@{#43063} Committed: https://chromium.googlesource.com/v8/v8/+/f68267aa276753b046439bd9f6e84dbe7d752b20

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -0 lines) Patch
M src/compiler/js-intrinsic-lowering.h View 1 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/js-intrinsic-lowering.cc View 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
Benedikt Meurer
3 years, 10 months ago (2017-02-09 12:24:43 UTC) #1
Jarin
lgtm https://codereview.chromium.org/2684193003/diff/1/src/compiler/js-intrinsic-lowering.h File src/compiler/js-intrinsic-lowering.h (right): https://codereview.chromium.org/2684193003/diff/1/src/compiler/js-intrinsic-lowering.h#newcode65 src/compiler/js-intrinsic-lowering.h:65: // converted to proper CodeStubAssembler based builtins. Now ...
3 years, 10 months ago (2017-02-09 14:23:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684193003/20001
3 years, 10 months ago (2017-02-09 14:44:13 UTC) #12
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 15:24:31 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/f68267aa276753b046439bd9f6e84dbe7d7...

Powered by Google App Engine
This is Rietveld 408576698