[cipd] ignore .cipd/* while extracting.

[cipd] ignore .cipd/* while extracting.

R=vadimsh@chromium.org
BUG=689359
Review-Url: https://codereview.chromium.org/2684133002
Committed: https://github.com/luci/luci-go/commit/27fda207cc185f378079bfa12f7a6c15f8f84cd4

[Vadim Sh., 2017-02-08 23:56:30]

https://codereview.chromium.org/2684133002/diff/1/cipd/client/cipd/local/read...
File cipd/client/cipd/local/reader.go (right):

https://codereview.chromium.org/2684133002/diff/1/cipd/client/cipd/local/read...
cipd/client/cipd/local/reader.go:76: type ExtractFilter func(zipName string)
bool
why not func(f File) bool?

https://codereview.chromium.org/2684133002/diff/1/cipd/client/cipd/local/read...
cipd/client/cipd/local/reader.go:183: case <-ctx.Done():
how is this different from what was there before?

[iannucci, 2017-02-09 00:03:48]

On 2017/02/08 23:56:30, Vadim Sh. wrote:
>
https://codereview.chromium.org/2684133002/diff/1/cipd/client/cipd/local/read...
> File cipd/client/cipd/local/reader.go (right):
> 
>
https://codereview.chromium.org/2684133002/diff/1/cipd/client/cipd/local/read...
> cipd/client/cipd/local/reader.go:76: type ExtractFilter func(zipName string)
> bool
> why not func(f File) bool?

Done

> 
>
https://codereview.chromium.org/2684133002/diff/1/cipd/client/cipd/local/read...
> cipd/client/cipd/local/reader.go:183: case <-ctx.Done():
> how is this different from what was there before?

https://github.com/golang/go/issues/14292 :(((((

[Vadim Sh., 2017-02-09 00:06:25]

lgtm

please also verufy by installing some old goma packages

[iannucci, 2017-02-09 00:08:03]

The CQ bit was checked by iannucci@chromium.org

[commit-bot: I haz the power, 2017-02-09 00:08:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[iannucci, 2017-02-09 00:09:28]

On 2017/02/09 00:06:25, Vadim Sh. wrote:
> lgtm
> 
> please also verufy by installing some old goma packages

yep did:

[P29155 15:50:27.820 client.go:1205 I] cipd: successfully fetched
infra_internal/goma/client/linux-amd64:8e887d49296181d205987cfc4a5c3d6fe1569545
[P29155 15:50:27.850 deployer.go:155 I] Deploying
infra_internal/goma/client/linux-amd64:8e887d49296181d205987cfc4a5c3d6fe1569545
into /s/infra/infra/go/src/github.com/luci/luci-go/cipd/client/cipd/local/foo(/)
[P29155 15:50:27.850 deployer.go:178 W] [non-fatal] ignoring internal file:
.cipd/config.json
[P29155 15:50:27.850 deployer.go:178 W] [non-fatal] ignoring internal file:
.cipd/pkgs/client_linux-amd64_8WNfrfwM3o/4e97d4d3e09c43985d77dbb0beb17c6298915274/.cipdpkg/manifest.json
[P29155 15:50:27.850 deployer.go:178 W] [non-fatal] ignoring internal file:
.cipd/pkgs/client_linux-amd64_8WNfrfwM3o/_current
[P29155 15:50:27.850 reader.go:254 I] cipd: about to extract 85.0 Mb (47 files)
[P29155 15:50:27.851 reader.go:291 I] cipd: extracting - 0%
[P29155 15:50:28.554 reader.go:291 I] cipd: extracting - 100%
[P29155 15:50:28.560 deployer.go:258 I] Successfully deployed
infra_internal/goma/client/linux-amd64:8e887d49296181d205987cfc4a5c3d6fe1569545
[P29155 15:50:28.571 client.go:1331 I] All changes applied.

[commit-bot: I haz the power, 2017-02-09 00:14:26]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486598883951590,
"parent_rev": "a3a9a22f2a349f800dee9ddb2802947d7fa85f06", "commit_rev":
"27fda207cc185f378079bfa12f7a6c15f8f84cd4"}

[commit-bot: I haz the power, 2017-02-09 00:14:29]

Description was changed from

==========
[cipd] ignore .cipd/* while extracting.

R=vadimsh@chromium.org
BUG=689359
==========

to

==========
[cipd] ignore .cipd/* while extracting.

R=vadimsh@chromium.org
BUG=689359

Review-Url: https://codereview.chromium.org/2684133002
Committed:
https://github.com/luci/luci-go/commit/27fda207cc185f378079bfa12f7a6c15f8f84cd4
==========

[commit-bot: I haz the power, 2017-02-09 00:14:30]

Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/27fda207cc185f378079bfa12f7a6c15f8f84cd4