Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 268413002: [SyncFS] Make DumpFiles async (Closed)

Created:
6 years, 7 months ago by peria
Modified:
6 years, 7 months ago
Reviewers:
nhiroki, tzik
CC:
chromium-reviews, kinuko+watch, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make DumpFiles method to run asynchronously in RemoteFileSyncService class and its child classes. BUG=347425 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270052

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Fix memory leak #

Patch Set 3 : work for a nit #

Total comments: 2

Patch Set 4 : Work for a nit #

Messages

Total messages: 9 (0 generated)
peria
PTL
6 years, 7 months ago (2014-05-09 05:46:04 UTC) #1
nhiroki
Looks good. https://codereview.chromium.org/268413002/diff/40001/chrome/browser/sync_file_system/drive_backend/sync_engine.cc File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right): https://codereview.chromium.org/268413002/diff/40001/chrome/browser/sync_file_system/drive_backend/sync_engine.cc#newcode312 chrome/browser/sync_file_system/drive_backend/sync_engine.cc:312: RelayCallbackToCurrentThread(FROM_HERE, callback)); Passing |callback| without the helper ...
6 years, 7 months ago (2014-05-09 05:56:25 UTC) #2
peria
https://codereview.chromium.org/268413002/diff/40001/chrome/browser/sync_file_system/drive_backend/sync_engine.cc File chrome/browser/sync_file_system/drive_backend/sync_engine.cc (right): https://codereview.chromium.org/268413002/diff/40001/chrome/browser/sync_file_system/drive_backend/sync_engine.cc#newcode312 chrome/browser/sync_file_system/drive_backend/sync_engine.cc:312: RelayCallbackToCurrentThread(FROM_HERE, callback)); On 2014/05/09 05:56:25, nhiroki wrote: > Passing ...
6 years, 7 months ago (2014-05-13 02:17:35 UTC) #3
nhiroki
lgtm. Please wait for tzik's review. https://codereview.chromium.org/268413002/diff/100001/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc File chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc (right): https://codereview.chromium.org/268413002/diff/100001/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc#newcode78 chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc:78: files); nit: probably ...
6 years, 7 months ago (2014-05-13 03:26:20 UTC) #4
tzik
lgtm
6 years, 7 months ago (2014-05-13 03:46:04 UTC) #5
peria
https://codereview.chromium.org/268413002/diff/100001/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc File chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc (right): https://codereview.chromium.org/268413002/diff/100001/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc#newcode78 chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc:78: files); On 2014/05/13 03:26:20, nhiroki wrote: > nit: probably ...
6 years, 7 months ago (2014-05-13 03:51:29 UTC) #6
peria
The CQ bit was checked by peria@chromium.org
6 years, 7 months ago (2014-05-13 03:51:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/peria@chromium.org/268413002/120001
6 years, 7 months ago (2014-05-13 03:52:30 UTC) #8
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 08:34:25 UTC) #9
Message was sent while issue was closed. 
Change committed as 270052

Powered by Google App Engine
This is Rietveld 408576698