chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc - Issue 268413002: [SyncFS] Make DumpFiles async

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc

Issue 268413002: [SyncFS] Make DumpFiles async (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Work for a nit Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc

diff --git a/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc b/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc

index 094f9d72ab0facc24bb8e9ef34271b25318c4756..2ca576424849154bf634ca09ea4da72f5aa55140 100644

--- a/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc

+++ b/chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.cc

@@ -72,9 +72,8 @@ void FileMetadataHandler::GetExtensions(const base::ListValue* args) {

web_ui()->CallJavascriptFunction("FileMetadata.onGetExtensions", list);

}

-void FileMetadataHandler::DidGetFileMetadata(const base::ListValue* files) {

- DCHECK(files);

- web_ui()->CallJavascriptFunction("FileMetadata.onGetFileMetadata", *files);

+void FileMetadataHandler::DidGetFileMetadata(const base::ListValue& files) {

+ web_ui()->CallJavascriptFunction("FileMetadata.onGetFileMetadata", files);

}

} // namespace syncfs_internals

« no previous file with comments | « chrome/browser/ui/webui/sync_file_system_internals/file_metadata_handler.h ('k') | no next file » | no next file with comments »