Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 2684103002: [Translate] Remove unused strings from components/translate_strings.grdp (Closed)

Created:
3 years, 10 months ago by Mathieu
Modified:
3 years, 10 months ago
Reviewers:
groby-ooo-7-16
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Translate] Remove unused strings from components/translate_strings.grdp BUG=690075 TEST=builds Review-Url: https://codereview.chromium.org/2684103002 Cr-Commit-Position: refs/heads/master@{#449138} Committed: https://chromium.googlesource.com/chromium/src/+/96b843574c741967951a158ccf924b453c3f301a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -15 lines) Patch
M components/translate_strings.grdp View 3 chunks +0 lines, -15 lines 0 comments Download

Messages

Total messages: 12 (8 generated)
Mathieu
Hi groby, PTAL!
3 years, 10 months ago (2017-02-08 19:31:18 UTC) #4
groby-ooo-7-16
lgtm
3 years, 10 months ago (2017-02-08 22:52:21 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684103002/1
3 years, 10 months ago (2017-02-08 23:22:58 UTC) #9
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 23:32:16 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/96b843574c741967951a158ccf92...

Powered by Google App Engine
This is Rietveld 408576698