Index: build/android/buildbot/bb_device_steps.py |
diff --git a/build/android/buildbot/bb_device_steps.py b/build/android/buildbot/bb_device_steps.py |
index dabe4b5f0c6a33b6fa184ddc8701b1d5f28ca875..b0460c3f97ca936d24d2ac848938185ed439b7f1 100755 |
--- a/build/android/buildbot/bb_device_steps.py |
+++ b/build/android/buildbot/bb_device_steps.py |
@@ -270,7 +270,7 @@ def RunWebkitLayoutTests(options): |
'full_results.json') |
if os.path.exists(full_results_path): |
full_results = json.load(open(full_results_path)) |
- unexpected_failures, unexpected_flakes, unexpected_passes = ( |
Dirk Pranke
2013/10/10 18:47:20
This is the important change.
landing w/o try jo
|
+ unexpected_passes, unexpected_flakes, unexpected_failures = ( |
_ParseLayoutTestResults(full_results)) |
if unexpected_failures: |
_PrintDashboardLink('failed', unexpected_failures, |
@@ -281,7 +281,12 @@ def RunWebkitLayoutTests(options): |
if unexpected_flakes: |
_PrintDashboardLink('unexpected flakes', unexpected_flakes, |
max_tests=10) |
+ |
+ if exit_code == 0 and (unexpected_passes or unexpected_flakes): |
+ # If exit_code != 0, RunCmd() will have already printed an error. |
+ bb_annotations.PrintWarning() |
else: |
+ bb_annotations.PrintError() |
bb_annotations.PrintMsg('?? (results missing)') |
if options.factory_properties.get('archive_webkit_results', False): |