fix swapped passes, failures in parsing layout test results

build/android/buildbot/bb_device_steps.py

 #!/usr/bin/env python
 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import collections
 import glob
 import hashlib
 import json
 import multiprocessing
@@ skipping 252 matching lines @@
 
   exit_code = RunCmd(['webkit/tools/layout_tests/run_webkit_tests.py'] +
                      cmd_args)
   if exit_code == 254:  # AKA -1, internal error.
     bb_annotations.PrintMsg('?? (crashed or hung)')
   else:
     full_results_path = os.path.join('..', 'layout-test-results',
                                      'full_results.json')
     if os.path.exists(full_results_path):
       full_results = json.load(open(full_results_path))
-      unexpected_failures, unexpected_flakes, unexpected_passes = (

[Dirk Pranke, 2013/10/10 18:47:20]

This is the important change. 

landing w/o try jobs as a build fix.

+      unexpected_passes, unexpected_flakes, unexpected_failures = (
           _ParseLayoutTestResults(full_results))
       if unexpected_failures:
         _PrintDashboardLink('failed', unexpected_failures,
                             max_tests=25)
       elif unexpected_passes:
         _PrintDashboardLink('unexpected passes', unexpected_passes,
                             max_tests=10)
       if unexpected_flakes:
         _PrintDashboardLink('unexpected flakes', unexpected_flakes,
                             max_tests=10)
+
+      if exit_code == 0 and (unexpected_passes or unexpected_flakes):
+        # If exit_code != 0, RunCmd() will have already printed an error.
+        bb_annotations.PrintWarning()
     else:
+      bb_annotations.PrintError()
       bb_annotations.PrintMsg('?? (results missing)')
 
   if options.factory_properties.get('archive_webkit_results', False):
     bb_annotations.PrintNamedStep('archive_webkit_results')
     base = 'https://storage.googleapis.com/chromium-layout-test-archives'
     builder_name = options.build_properties.get('buildername', '')
     build_number = str(options.build_properties.get('buildnumber', ''))
     results_link = '%s/%s/%s/layout-test-results/results.html' % (
         base, EscapeBuilderName(builder_name), build_number)
     bb_annotations.PrintLink('results', results_link)
@@ skipping 274 matching lines @@
   setattr(options, 'target', options.factory_properties.get('target', 'Debug'))
   if options.coverage_bucket:
     setattr(options, 'coverage_dir',
             os.path.join(CHROME_OUT_DIR, options.target, 'coverage'))
 
   MainTestWrapper(options)
 
 
 if __name__ == '__main__':
   sys.exit(main(sys.argv))