Issue 26841003: fix swapped passes, failures in parsing layout test results

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 26841003: fix swapped passes, failures in parsing layout test results (Closed)

Created:
7 years, 2 months ago by Dirk Pranke

Modified:
7 years, 2 months ago

Reviewers:
Isaac (away)

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

fix swapped passes, failures in parsing layout test results Also, make the step fail if the fulL_results.json file is missing, and make the step warn if we get unexpected flakes or passes. TBR=ilevy@chromium.org BUG=293920 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227967

Patch Set 1 #

Patch Set 2 : rietveld!!!! #

Total comments: 1

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -1 line)			Patch
	M	build/android/buildbot/bb_device_steps.py	View		2 chunks	+6 lines, -1 line	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Dirk Pranke

Committed patchset #2 manually as r227967 (presubmit successful).

7 years, 2 months ago (2013-10-10 18:47:19 UTC) #2

Dirk Pranke

7 years, 2 months ago (2013-10-10 18:47:19 UTC) #3

Message was sent while issue was closed.

https://codereview.chromium.org/26841003/diff/3001/build/android/buildbot/bb_...
File build/android/buildbot/bb_device_steps.py (left):

https://codereview.chromium.org/26841003/diff/3001/build/android/buildbot/bb_...
build/android/buildbot/bb_device_steps.py:273: unexpected_failures,
unexpected_flakes, unexpected_passes = (
This is the important change. 

landing w/o try jobs as a build fix.

Expand Messages | Collapse Messages