Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(274)

Issue 2684083002: Add '//ui/events:dom_keycode_converter' to the deps list for ozone wayland platform. (Closed)

Created:
3 years, 10 months ago by andrea.azzarone
Modified:
3 years, 10 months ago
CC:
chromium-reviews, kalyank, ozone-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build failure for ozone wayland platform. Add '//ui/events:dom_keycode_converter' to the deps list for ozone wayland platform. BUG=687561 Review-Url: https://codereview.chromium.org/2684083002 Cr-Commit-Position: refs/heads/master@{#449093} Committed: https://chromium.googlesource.com/chromium/src/+/1fb5e409dc2f358ed1f73599bf72b1fde74bf6f9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M ui/ozone/platform/wayland/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
andrea.azzarone
Fix a build failure as per issue 687561.
3 years, 10 months ago (2017-02-08 17:45:46 UTC) #3
spang
lgtm
3 years, 10 months ago (2017-02-08 18:02:28 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684083002/1
3 years, 10 months ago (2017-02-08 18:03:11 UTC) #8
commit-bot: I haz the power
The author andrea.azzarone@canonical.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
3 years, 10 months ago (2017-02-08 18:03:13 UTC) #10
andrea.azzarone
On 2017/02/08 18:03:13, commit-bot: I haz the power wrote: > The author mailto:andrea.azzarone@canonical.com has not ...
3 years, 10 months ago (2017-02-08 18:21:01 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684083002/1
3 years, 10 months ago (2017-02-08 19:33:01 UTC) #13
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 21:18:08 UTC) #16
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1fb5e409dc2f358ed1f73599bf72...

Powered by Google App Engine
This is Rietveld 408576698