[ObjC ARC] Converts ios/chrome/browser/upgrade:unit_tests to ARC.

[ObjC ARC] Converts ios/chrome/browser/upgrade:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2684073007
Cr-Commit-Position: refs/heads/master@{#449950}
Committed: https://chromium.googlesource.com/chromium/src/+/d7d0dbb08c8321e85a1ff056dd2e269f68c779f6

[lody, 2017-02-09 16:39:58]

The CQ bit was checked by lod@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-09 16:40:26]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-09 17:37:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-09 17:37:28]

Dry run: This issue passed the CQ dry run.

[lody, 2017-02-10 09:06:11]

lod@chromium.org changed reviewers:
+ sdefresne@chromium.org, stkhapugin@chromium.org

[lody, 2017-02-10 09:06:15]

Please review, thanks.

[sdefresne, 2017-02-10 10:17:43]

lgtm

There's lots of nits in that converted file, but they pre-exists your CL, so no
need to change them.

https://codereview.chromium.org/2684073007/diff/1/ios/chrome/browser/upgrade/...
File ios/chrome/browser/upgrade/upgrade_center_unittest.mm (right):

https://codereview.chromium.org/2684073007/diff/1/ios/chrome/browser/upgrade/...
ios/chrome/browser/upgrade/upgrade_center_unittest.mm:36: UpgradeCenterTest*
test_;  // weak
Remove "// weak".

[lody, 2017-02-13 10:47:14]

https://codereview.chromium.org/2684073007/diff/1/ios/chrome/browser/upgrade/...
File ios/chrome/browser/upgrade/upgrade_center_unittest.mm (right):

https://codereview.chromium.org/2684073007/diff/1/ios/chrome/browser/upgrade/...
ios/chrome/browser/upgrade/upgrade_center_unittest.mm:36: UpgradeCenterTest*
test_;  // weak
On 2017/02/10 10:17:43, sdefresne wrote:
> Remove "// weak".

Done.

[lody, 2017-02-13 10:47:17]

The CQ bit was checked by lod@chromium.org

[lody, 2017-02-13 10:47:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
sdefresne@chromium.org
Link to the patchset: https://codereview.chromium.org/2684073007/#ps20001
(title: "remove comment")

[commit-bot: I haz the power, 2017-02-13 10:47:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 11:46:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-13 11:46:33]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[lody, 2017-02-13 14:29:05]

The CQ bit was checked by lod@chromium.org

[commit-bot: I haz the power, 2017-02-13 14:29:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-13 14:32:52]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486996145580210,
"parent_rev": "c3445479cdb518237ecc8ef0e9881fb5d0315260", "commit_rev":
"d7d0dbb08c8321e85a1ff056dd2e269f68c779f6"}

[commit-bot: I haz the power, 2017-02-13 14:33:23]

Description was changed from

==========
[ObjC ARC] Converts ios/chrome/browser/upgrade:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None
==========

to

==========
[ObjC ARC] Converts ios/chrome/browser/upgrade:unit_tests to ARC.

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2684073007
Cr-Commit-Position: refs/heads/master@{#449950}
Committed:
https://chromium.googlesource.com/chromium/src/+/d7d0dbb08c8321e85a1ff056dd2e...
==========

[commit-bot: I haz the power, 2017-02-13 14:33:27]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d7d0dbb08c8321e85a1ff056dd2e...