Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2684073003: third_party: Amend version 3 of remote shell protocol (Closed)

Created:
3 years, 10 months ago by Dominik Laskowski
Modified:
3 years, 10 months ago
Reviewers:
reveman, oshima
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

third_party: Amend version 3 of remote shell protocol Instead of toggling the server-side dragging state in response to client requests, the compositor will detect conditions that initiate/abort dragging, and instruct the client to transition in/out of a new "moving" window state. As a prerequisite, the compositor must synchronize window state transitions with the client. This is also needed to prevent racy geometry updates, notably when entering immersive mode while dragging. BUG=642894 TEST=None Review-Url: https://codereview.chromium.org/2684073003 Cr-Commit-Position: refs/heads/master@{#450834} Committed: https://chromium.googlesource.com/chromium/src/+/650201c6a66c743754533d723a2dbeab9414d9cb

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Patch Set 5 : Fix compilation error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -129 lines) Patch
M components/exo/wayland/server.cc View 1 2 3 4 2 chunks +2 lines, -7 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-client-protocol.h View 1 8 chunks +94 lines, -75 lines 0 comments Download
M third_party/wayland-protocols/include/protocol/remote-shell-unstable-v1-server-protocol.h View 1 5 chunks +132 lines, -28 lines 0 comments Download
M third_party/wayland-protocols/protocol/remote-shell-protocol.c View 1 1 chunk +3 lines, -4 lines 0 comments Download
M third_party/wayland-protocols/unstable/remote-shell/remote-shell-unstable-v1.xml View 1 5 chunks +18 lines, -15 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 17 (13 generated)
Dominik Laskowski
PTAL. Will rebase shortly.
3 years, 10 months ago (2017-02-08 16:28:05 UTC) #2
reveman
lgtm
3 years, 10 months ago (2017-02-08 16:54:26 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2684073003/80001
3 years, 10 months ago (2017-02-15 21:24:50 UTC) #14
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 23:35:55 UTC) #17
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/650201c6a66c743754533d723a2d...

Powered by Google App Engine
This is Rietveld 408576698