[turbofan] Use fast stub for ForInPrepare and ForInNext

[turbofan] Use fast stub for ForInPrepare and ForInNext

Review-Url: https://codereview.chromium.org/2684043002
Cr-Commit-Position: refs/heads/master@{#43040}
Committed: https://chromium.googlesource.com/v8/v8/+/d21ed46d01a4bbe3812184279bf0ba86137103a0

[Camillo Bruni, 2017-02-08 12:06:39]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 12:06:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Camillo Bruni, 2017-02-08 12:08:17]

cbruni@chromium.org changed reviewers:
+ bmeurer@chromium.org, danno@chromium.org

[commit-bot: I haz the power, 2017-02-08 12:13:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 12:13:56]

Dry run: Try jobs failed on following builders:
  v8_linux64_verify_csa_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_verify_csa_rel_n...)

[danno, 2017-02-08 12:19:10]

lgtm with comment

https://codereview.chromium.org/2684043002/diff/1/src/builtins/builtins-objec...
File src/builtins/builtins-object.cc (right):

https://codereview.chromium.org/2684043002/diff/1/src/builtins/builtins-objec...
src/builtins/builtins-object.cc:928: Return(ForInFilter(key, object, context));
Can't you remove the version of ForInNext in runtime.h now if this is a complete
replacement?

[Benedikt Meurer, 2017-02-08 13:27:56]

LGTM, thanks.

[Camillo Bruni, 2017-02-08 13:45:33]

Description was changed from

==========
[turbofan] Use fast stub for ForInPrepare and ForInNext

BUG=
==========

to

==========
[turbofan] Use fast stub for ForInPrepare and ForInNext
==========

[Camillo Bruni, 2017-02-08 13:45:52]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-08 13:46:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 14:14:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-08 14:14:08]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2017-02-08 14:25:14]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2017-02-08 14:25:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
bmeurer@chromium.org, danno@chromium.org
Link to the patchset: https://codereview.chromium.org/2684043002/#ps20001
(title: "add missing SmiUntag and remove ForInNext RT function")

[commit-bot: I haz the power, 2017-02-08 14:25:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-08 14:26:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1486563914052800,
"parent_rev": "2237106ae2c507d32a199d1a039ffae6a5619eb6", "commit_rev":
"d21ed46d01a4bbe3812184279bf0ba86137103a0"}

[commit-bot: I haz the power, 2017-02-08 14:27:01]

Description was changed from

==========
[turbofan] Use fast stub for ForInPrepare and ForInNext
==========

to

==========
[turbofan] Use fast stub for ForInPrepare and ForInNext

Review-Url: https://codereview.chromium.org/2684043002
Cr-Commit-Position: refs/heads/master@{#43040}
Committed:
https://chromium.googlesource.com/v8/v8/+/d21ed46d01a4bbe3812184279bf0ba86137...
==========

[commit-bot: I haz the power, 2017-02-08 14:27:02]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/d21ed46d01a4bbe3812184279bf0ba86137...

[rmcilroy, 2017-02-08 23:37:21]

rmcilroy@chromium.org changed reviewers:
+ rmcilroy@chromium.org

[rmcilroy, 2017-02-08 23:37:22]

https://codereview.chromium.org/2684043002/diff/20001/src/builtins/builtins-o...
File src/builtins/builtins-object.cc (right):

https://codereview.chromium.org/2684043002/diff/20001/src/builtins/builtins-o...
src/builtins/builtins-object.cc:955: TailCallRuntime(Runtime::kForInPrepare,
context, object);
Could we use this same code (inlined) in Interpreter::DoForInPrepare and / or
move some of the logic there in here, and then share it between the interpreter
and the builtin ?  (ditto with ForInNext).

[Camillo Bruni, 2017-02-09 10:25:05]

https://codereview.chromium.org/2684043002/diff/20001/src/builtins/builtins-o...
File src/builtins/builtins-object.cc (right):

https://codereview.chromium.org/2684043002/diff/20001/src/builtins/builtins-o...
src/builtins/builtins-object.cc:955: TailCallRuntime(Runtime::kForInPrepare,
context, object);
On 2017/02/08 at 23:37:22, rmcilroy wrote:
> Could we use this same code (inlined) in Interpreter::DoForInPrepare and / or
move some of the logic there in here, and then share it between the interpreter
and the builtin ?  (ditto with ForInNext).

I spent too much time chatting with people yesterday, but I planned to do that
cleanup as well for ignition :P

[rmcilroy, 2017-02-09 10:41:11]

On 2017/02/09 10:25:05, Camillo Bruni wrote:
>
https://codereview.chromium.org/2684043002/diff/20001/src/builtins/builtins-o...
> File src/builtins/builtins-object.cc (right):
> 
>
https://codereview.chromium.org/2684043002/diff/20001/src/builtins/builtins-o...
> src/builtins/builtins-object.cc:955: TailCallRuntime(Runtime::kForInPrepare,
> context, object);
> On 2017/02/08 at 23:37:22, rmcilroy wrote:
> > Could we use this same code (inlined) in Interpreter::DoForInPrepare and /
or
> move some of the logic there in here, and then share it between the
interpreter
> and the builtin ?  (ditto with ForInNext).
> 
> I spent too much time chatting with people yesterday, but I planned to do that
> cleanup as well for ignition :P

Cool, thanks!