Copy cdb.exe to build_root_dir so it's available to isolated tests

Copy cdb.exe to build_root_dir so it's available to isolated tests

BUG=690344
R=dpranke@chromium.org,scottmg@chromium.org

Review-Url: https://codereview.chromium.org/2684033010
Cr-Commit-Position: refs/heads/master@{#450820}
Committed: https://chromium.googlesource.com/chromium/src/+/6c29ace559b19a2071f4402cd201d162abd1b7ac

[jochen (gone - plz use gerrit), 2017-02-10 09:39:21]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-10 09:39:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 10:31:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-10 10:31:08]

Dry run: This issue passed the CQ dry run.

[scottmg, 2017-02-10 15:52:32]

https://codereview.chromium.org/2684033010/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/2684033010/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:330: _CopyRuntimeImpl(os.path.join(target_dir, 'cdb.exe'),
cdb_exe)
I don't think this will run isolated without some dlls, at least dbgeng.dll,
dbghelp.dll, and dbgmodel.dll.

[jochen (gone - plz use gerrit), 2017-02-10 15:56:39]

https://codereview.chromium.org/2684033010/diff/1/build/vs_toolchain.py
File build/vs_toolchain.py (right):

https://codereview.chromium.org/2684033010/diff/1/build/vs_toolchain.py#newco...
build/vs_toolchain.py:330: _CopyRuntimeImpl(os.path.join(target_dir, 'cdb.exe'),
cdb_exe)
On 2017/02/10 at 15:52:32, scottmg wrote:
> I don't think this will run isolated without some dlls, at least dbgeng.dll,
dbghelp.dll, and dbgmodel.dll.

Is there some kind of ldd equivalent that lists all required DLLs?

[scottmg, 2017-02-10 16:02:25]

On 2017/02/10 15:56:39, jochen wrote:
> https://codereview.chromium.org/2684033010/diff/1/build/vs_toolchain.py
> File build/vs_toolchain.py (right):
> 
>
https://codereview.chromium.org/2684033010/diff/1/build/vs_toolchain.py#newco...
> build/vs_toolchain.py:330: _CopyRuntimeImpl(os.path.join(target_dir,
'cdb.exe'),
> cdb_exe)
> On 2017/02/10 at 15:52:32, scottmg wrote:
> > I don't think this will run isolated without some dlls, at least dbgeng.dll,
> dbghelp.dll, and dbgmodel.dll.
> 
> Is there some kind of ldd equivalent that lists all required DLLs?

http://www.dependencywalker.com/ but it'll only get static dependencies (i.e.
not LoadLibrary()d) of course.

[Dirk Pranke, 2017-02-10 18:06:18]

https://codereview.chromium.org/2684033010/diff/1/build/toolchain/win/BUILD.gn
File build/toolchain/win/BUILD.gn (right):

https://codereview.chromium.org/2684033010/diff/1/build/toolchain/win/BUILD.g...
build/toolchain/win/BUILD.gn:56: }
Can we merge this into the prior exec_script() call to make things faster?

[jochen (gone - plz use gerrit), 2017-02-14 10:10:09]

On 2017/02/10 at 16:02:25, scottmg wrote:
> On 2017/02/10 15:56:39, jochen wrote:
> > https://codereview.chromium.org/2684033010/diff/1/build/vs_toolchain.py
> > File build/vs_toolchain.py (right):
> > 
> >
https://codereview.chromium.org/2684033010/diff/1/build/vs_toolchain.py#newco...
> > build/vs_toolchain.py:330: _CopyRuntimeImpl(os.path.join(target_dir,
'cdb.exe'),
> > cdb_exe)
> > On 2017/02/10 at 15:52:32, scottmg wrote:
> > > I don't think this will run isolated without some dlls, at least
dbgeng.dll,
> > dbghelp.dll, and dbgmodel.dll.
> > 
> > Is there some kind of ldd equivalent that lists all required DLLs?
> 
> http://www.dependencywalker.com/ but it'll only get static dependencies (i.e.
not LoadLibrary()d) of course.

looks like those three DLLs will do the trick

[jochen (gone - plz use gerrit), 2017-02-15 09:27:58]

The CQ bit was checked by jochen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-15 09:28:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jochen (gone - plz use gerrit), 2017-02-15 09:28:36]

ptal

[commit-bot: I haz the power, 2017-02-15 09:39:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-15 09:39:48]

Dry run: This issue passed the CQ dry run.

[scottmg, 2017-02-15 17:42:29]

lgtm

My only concern is copying dbghelp.dll to the output dir because Chrome loads
that to do in process stack traces. Previously that would have generally been
the system one, now this one will be found first.

In particular I would be concerned on downlevel OS's. The current DLL is tagged
with 6.01 == Win7/Server 2008 R2, so in theory it should be OK, but just fyi, as
it might manifest as hangs or unexpected behaviour on crashes, especially if we
have any bots that early no-Service Pack Win7's or something.

[Dirk Pranke, 2017-02-15 19:37:20]

If scottmg@ is okay with it, I'm okay with it :). lgtm.

[jochen (gone - plz use gerrit), 2017-02-15 21:44:25]

The CQ bit was checked by jochen@chromium.org

[commit-bot: I haz the power, 2017-02-15 21:45:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-15 22:45:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1487195065809980,
"parent_rev": "8acf5dcbc4e83fad7f23eb0380e0635058a636bc", "commit_rev":
"6c29ace559b19a2071f4402cd201d162abd1b7ac"}

[commit-bot: I haz the power, 2017-02-15 22:46:13]

Description was changed from

==========
Copy cdb.exe to build_root_dir so it's available to isolated tests

BUG=690344
R=dpranke@chromium.org,scottmg@chromium.org
==========

to

==========
Copy cdb.exe to build_root_dir so it's available to isolated tests

BUG=690344
R=dpranke@chromium.org,scottmg@chromium.org

Review-Url: https://codereview.chromium.org/2684033010
Cr-Commit-Position: refs/heads/master@{#450820}
Committed:
https://chromium.googlesource.com/chromium/src/+/6c29ace559b19a2071f4402cd201...
==========

[commit-bot: I haz the power, 2017-02-15 22:46:14]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/6c29ace559b19a2071f4402cd201...

[Sébastien Marchand, 2017-02-16 18:55:03]

sebmarchand@chromium.org changed reviewers:
+ sebmarchand@chromium.org

[Sébastien Marchand, 2017-02-16 18:55:04]

This seems to break the symbol upload step on the official builders (see
crbug.com/693147), not sure why yet, still looking.

[scottmg, 2017-02-16 18:58:11]

On 2017/02/16 18:55:04, Sébastien Marchand wrote:
> This seems to break the symbol upload step on the official builders (see
> crbug.com/693147), not sure why yet, still looking.

Darn, sorry. I guess it changes which dbghelp gets used. I think it's safe to
revert.

[scottmg, 2017-02-16 19:04:46]

On 2017/02/16 18:58:11, scottmg wrote:
> On 2017/02/16 18:55:04, Sébastien Marchand wrote:
> > This seems to break the symbol upload step on the official builders (see
> > crbug.com/693147), not sure why yet, still looking.
> 
> Darn, sorry. I guess it changes which dbghelp gets used. I think it's safe to
> revert.

jochen already fixed in crbug.com/692907 for future reference.