Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2683993004: [Chromecast] Fix issue where new playback rate was never used (Closed)

Created:
3 years, 10 months ago by kmackay
Modified:
3 years, 10 months ago
Reviewers:
slan, halliwell, jameswest
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Chromecast] Fix issue where new playback rate was never used In some cases where the old playback rate was 1.0 and was in passthrough mode, the new playback rate would never start being used. This uses a more correct check to determine if the old rate is complete. BUG= internal b/27450476 Review-Url: https://codereview.chromium.org/2683993004 Cr-Commit-Position: refs/heads/master@{#449209} Committed: https://chromium.googlesource.com/chromium/src/+/88019c0dd11547f36d8a3f80c280652dfd58c1d9

Patch Set 1 #

Patch Set 2 : add check during bypass #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -5 lines) Patch
M chromecast/media/cma/backend/alsa/audio_decoder_alsa.cc View 1 3 chunks +14 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
kmackay
3 years, 10 months ago (2017-02-08 23:36:28 UTC) #2
jameswest
lgtm
3 years, 10 months ago (2017-02-08 23:48:45 UTC) #3
halliwell
On 2017/02/08 23:48:45, jameswest wrote: > lgtm is there a bug link? lgtm
3 years, 10 months ago (2017-02-09 00:40:22 UTC) #4
kmackay
On 2017/02/09 00:40:22, halliwell wrote: > is there a bug link? Added bug link.
3 years, 10 months ago (2017-02-09 05:33:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683993004/20001
3 years, 10 months ago (2017-02-09 05:34:31 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-09 05:44:52 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/88019c0dd11547f36d8a3f80c280...

Powered by Google App Engine
This is Rietveld 408576698