Move toEventTarget to EventTarget

third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp

Index: third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
index 2511fed997fea08cadb67a20585b8969ea65230d..488a7d0bc8746707ee088ca7390efc27d8e7b930 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8Binding.cpp
@@ -799,7 +799,7 @@ EventTarget* toEventTarget(v8::Isolate* isolate, v8::Local<v8::Value> value) {
     return static_cast<EventTarget*>(window);

[jbroman, 2017/02/10 16:04:27]

nit: While you're here, you could remove this static_cast (it's a little weird
to use static_cast to upcast). But that's not really part of this CL.

[adithyas, 2017/02/10 18:39:49]

Removed it.

   if (V8EventTarget::hasInstance(value, isolate)) {
     v8::Local<v8::Object> object = v8::Local<v8::Object>::Cast(value);
-    return toWrapperTypeInfo(object)->toEventTarget(object);
+    return EventTarget::toEventTarget(object);

[jbroman, 2017/02/10 16:03:16]

Given that, you can inline the other toEventTarget here, as it becomes the sole
call site (at which point the hasInstance and the eventTargetInheritance bit are
redundant). So after inlining that here, you won't need any changes to
EventTarget.h and EventTarget.cpp.

If that all seems reasonable, we might be able to remove the
eventTargetInheritance bit from WrapperTypeInfo in a followup CL.

[adithyas, 2017/02/10 18:39:49]

Done! I'll remove the wrapperType eventTargetInheritance check (and the field
itself) in a separate CL.

   }
   return 0;
 }