Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2683993002: Fix heap overflow caused by small buffer size (Closed)

Created:
3 years, 10 months ago by qiankun
Modified:
3 years, 10 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix heap overflow caused by small buffer size Calling DoTexImage with pixels_size == 1 for 1x1 size texture is not big enough for some formats. Use the specified texture size to calculate pixles_size. BUG=681641 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2683993002 Cr-Commit-Position: refs/heads/master@{#449083} Committed: https://chromium.googlesource.com/chromium/src/+/c2a73adc758f50c5ee8bf8e79ac6fe3fe2c52ce3

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
qiankun
PTAL
3 years, 10 months ago (2017-02-08 08:28:15 UTC) #4
Zhenyao Mo
On 2017/02/08 08:28:15, qiankun wrote: > PTAL lgtm (although now this becomes a heavier workaround)
3 years, 10 months ago (2017-02-08 19:32:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683993002/1
3 years, 10 months ago (2017-02-08 19:33:57 UTC) #7
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 20:39:52 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c2a73adc758f50c5ee8bf8e79ac6...

Powered by Google App Engine
This is Rietveld 408576698