Gtk3: More fixes and refactorings

Gtk3: More fixes and refactorings

This CL
* Uses entry colors instead of window colors for the NTP
* Fixes a leak involving ScopedGObject
* Simplifies how background and border colors are calculated
* Adds the ".label" class only on versions of Gtk before 3.20
* Fixes text selection colors on one theme
* Updates the doc to reflect the new way colors are calculated

BUG=132847
Review-Url: https://codereview.chromium.org/2683953005
Cr-Commit-Position: refs/heads/master@{#449709}
Committed: https://chromium.googlesource.com/chromium/src/+/419a91a17b8de0ac78ff66c29e894fa38fc11c6c

[Tom (Use chromium acct), 2017-02-10 02:57:27]

Patchset #1 (id:1) has been deleted

[Tom (Use chromium acct), 2017-02-10 02:57:34]

Patchset #1 (id:20001) has been deleted

[Tom (Use chromium acct), 2017-02-10 03:04:30]

Description was changed from

==========
Gtk3: More fixes and refactorings
==========

to

==========
Gtk3: More fixes and refactorings

This CL
* Uses entry colors instead of window colors for the NTP
* Fixes a leak involving ScopedGObject
* Simplifies how background and border colors are calculated
* Adds the ".label" class only on versions of Gtk before 3.20
* Fixes text selection colors on one theme
* Updates the doc to reflect the new way colors are calculated
==========

[Tom (Use chromium acct), 2017-02-10 03:04:30]

thomasanderson@google.com changed reviewers:
+ erg@chromium.org

[Tom (Use chromium acct), 2017-02-10 03:11:30]

erg ptal

I've tested about a dozen themes across Gtk 3.10, 3.18, and 3.20, and this CL
fixes all the bugs (that I've noticed)

The biggest change is with how background colors are calculated.  We no longer
render into a single pixel, but a 24x24 bitmap.  Themes just kept doing crazy
CSS hacks which broke the colors

[Tom (Use chromium acct), 2017-02-10 03:14:04]

Patchset #1 (id:40001) has been deleted

[Elliot Glaysher, 2017-02-10 18:13:41]

https://codereview.chromium.org/2683953005/diff/60001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtkui/gtk_util.h (right):

https://codereview.chromium.org/2683953005/diff/60001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtkui/gtk_util.h:161: std::function<void(GtkStyleContext*)>
unref_style_context =
I don't understand why you're declaring an anonymous function, assigning it to a
std::function and then calling it. If that's actually part of the magic of the
workaround, please explain it in the comment.

[Tom (Use chromium acct), 2017-02-10 18:54:40]

https://codereview.chromium.org/2683953005/diff/60001/chrome/browser/ui/libgt...
File chrome/browser/ui/libgtkui/gtk_util.h (right):

https://codereview.chromium.org/2683953005/diff/60001/chrome/browser/ui/libgt...
chrome/browser/ui/libgtkui/gtk_util.h:161: std::function<void(GtkStyleContext*)>
unref_style_context =
On 2017/02/10 18:13:41, Elliot Glaysher wrote:
> I don't understand why you're declaring an anonymous function, assigning it to
a
> std::function and then calling it. If that's actually part of the magic of the
> workaround, please explain it in the comment.

oh, it's actually recursive

However, I don't think it was clear written this way, so I've refactored it to
just use a loop instead

[Elliot Glaysher, 2017-02-10 18:56:04]

lgtm

Please add the bug number to this patch, too.

[Tom (Use chromium acct), 2017-02-10 19:01:36]

Description was changed from

==========
Gtk3: More fixes and refactorings

This CL
* Uses entry colors instead of window colors for the NTP
* Fixes a leak involving ScopedGObject
* Simplifies how background and border colors are calculated
* Adds the ".label" class only on versions of Gtk before 3.20
* Fixes text selection colors on one theme
* Updates the doc to reflect the new way colors are calculated
==========

to

==========
Gtk3: More fixes and refactorings

This CL
* Uses entry colors instead of window colors for the NTP
* Fixes a leak involving ScopedGObject
* Simplifies how background and border colors are calculated
* Adds the ".label" class only on versions of Gtk before 3.20
* Fixes text selection colors on one theme
* Updates the doc to reflect the new way colors are calculated

BUG=132847
==========

[Tom (Use chromium acct), 2017-02-10 19:01:49]

On 2017/02/10 18:56:04, Elliot Glaysher wrote:
> lgtm
> 
> Please add the bug number to this patch, too.

done

[Tom (Use chromium acct), 2017-02-10 19:01:52]

The CQ bit was checked by thomasanderson@google.com

[commit-bot: I haz the power, 2017-02-10 19:03:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-10 20:05:52]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1486753312988170,
"parent_rev": "b0e1c97b053d2f740f3975b76c49f7e62dfc3f1b", "commit_rev":
"419a91a17b8de0ac78ff66c29e894fa38fc11c6c"}

[commit-bot: I haz the power, 2017-02-10 20:07:16]

Description was changed from

==========
Gtk3: More fixes and refactorings

This CL
* Uses entry colors instead of window colors for the NTP
* Fixes a leak involving ScopedGObject
* Simplifies how background and border colors are calculated
* Adds the ".label" class only on versions of Gtk before 3.20
* Fixes text selection colors on one theme
* Updates the doc to reflect the new way colors are calculated

BUG=132847
==========

to

==========
Gtk3: More fixes and refactorings

This CL
* Uses entry colors instead of window colors for the NTP
* Fixes a leak involving ScopedGObject
* Simplifies how background and border colors are calculated
* Adds the ".label" class only on versions of Gtk before 3.20
* Fixes text selection colors on one theme
* Updates the doc to reflect the new way colors are calculated

BUG=132847

Review-Url: https://codereview.chromium.org/2683953005
Cr-Commit-Position: refs/heads/master@{#449709}
Committed:
https://chromium.googlesource.com/chromium/src/+/419a91a17b8de0ac78ff66c29e89...
==========

[commit-bot: I haz the power, 2017-02-10 20:07:17]

Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/419a91a17b8de0ac78ff66c29e89...