Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3577)

Issue 2683953005: Gtk3: More fixes and refactorings (Closed)

Created:
3 years, 6 months ago by Tom (Use chromium acct)
Modified:
3 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Gtk3: More fixes and refactorings This CL * Uses entry colors instead of window colors for the NTP * Fixes a leak involving ScopedGObject * Simplifies how background and border colors are calculated * Adds the ".label" class only on versions of Gtk before 3.20 * Fixes text selection colors on one theme * Updates the doc to reflect the new way colors are calculated BUG=132847 Review-Url: https://codereview.chromium.org/2683953005 Cr-Commit-Position: refs/heads/master@{#449709} Committed: https://chromium.googlesource.com/chromium/src/+/419a91a17b8de0ac78ff66c29e894fa38fc11c6c

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove lambda #

Unified diffs Side-by-side diffs Delta from patch set Stats (+234 lines, -223 lines) Patch
M chrome/browser/ui/libgtkui/gtk_ui.cc View 3 chunks +12 lines, -13 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.h View 1 6 chunks +49 lines, -25 lines 0 comments Download
M chrome/browser/ui/libgtkui/gtk_util.cc View 8 chunks +115 lines, -113 lines 0 comments Download
M chrome/browser/ui/libgtkui/native_theme_gtk3.cc View 11 chunks +50 lines, -53 lines 0 comments Download
M docs/linux_gtk_theme_integration.md View 2 chunks +8 lines, -19 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (9 generated)
Tom (Use chromium acct)
erg ptal I've tested about a dozen themes across Gtk 3.10, 3.18, and 3.20, and ...
3 years, 6 months ago (2017-02-10 03:11:30 UTC) #5
Elliot Glaysher
https://codereview.chromium.org/2683953005/diff/60001/chrome/browser/ui/libgtkui/gtk_util.h File chrome/browser/ui/libgtkui/gtk_util.h (right): https://codereview.chromium.org/2683953005/diff/60001/chrome/browser/ui/libgtkui/gtk_util.h#newcode161 chrome/browser/ui/libgtkui/gtk_util.h:161: std::function<void(GtkStyleContext*)> unref_style_context = I don't understand why you're declaring ...
3 years, 6 months ago (2017-02-10 18:13:41 UTC) #7
Tom (Use chromium acct)
https://codereview.chromium.org/2683953005/diff/60001/chrome/browser/ui/libgtkui/gtk_util.h File chrome/browser/ui/libgtkui/gtk_util.h (right): https://codereview.chromium.org/2683953005/diff/60001/chrome/browser/ui/libgtkui/gtk_util.h#newcode161 chrome/browser/ui/libgtkui/gtk_util.h:161: std::function<void(GtkStyleContext*)> unref_style_context = On 2017/02/10 18:13:41, Elliot Glaysher wrote: ...
3 years, 6 months ago (2017-02-10 18:54:40 UTC) #8
Elliot Glaysher
lgtm Please add the bug number to this patch, too.
3 years, 6 months ago (2017-02-10 18:56:04 UTC) #9
Tom (Use chromium acct)
On 2017/02/10 18:56:04, Elliot Glaysher wrote: > lgtm > > Please add the bug number ...
3 years, 6 months ago (2017-02-10 19:01:49 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683953005/80001
3 years, 6 months ago (2017-02-10 19:03:10 UTC) #13
commit-bot: I haz the power
3 years, 6 months ago (2017-02-10 20:07:17 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/419a91a17b8de0ac78ff66c29e89...

Powered by Google App Engine
This is Rietveld 408576698