Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 2683863004: [RuntimeStats] Show all entries which are in at least one version. (Closed)

Created:
3 years, 10 months ago by rmcilroy
Modified:
3 years, 10 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[RuntimeStats] Show all entries which are in at least one version. Previously the runtime stats tool would only show entries which were in the baseline version. This change adds any entries which exist in any version to the comparison table, which would otherwise not appear anywhere unless that version was selected as the baseline version. NOTRY=true Review-Url: https://codereview.chromium.org/2683863004 Cr-Commit-Position: refs/heads/master@{#43045} Committed: https://chromium.googlesource.com/v8/v8/+/d2c565215be4f44a6e879ed6f708151f79a95d48

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -95 lines) Patch
M tools/callstats.html View 29 chunks +95 lines, -95 lines 2 comments Download

Messages

Total messages: 9 (5 generated)
rmcilroy
Hi Camillo. I got really confused wondering where any of the background compile entries where ...
3 years, 10 months ago (2017-02-08 15:03:37 UTC) #2
Camillo Bruni
LGTM Thanks! I wanted to fix this at some point but got used to somehow ...
3 years, 10 months ago (2017-02-08 15:13:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2683863004/1
3 years, 10 months ago (2017-02-08 17:28:38 UTC) #6
commit-bot: I haz the power
3 years, 10 months ago (2017-02-08 17:30:02 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/d2c565215be4f44a6e879ed6f708151f79a...

Powered by Google App Engine
This is Rietveld 408576698